Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 10915153: Cleanup: Simplify some extension API code. (Closed)

Created:
8 years, 3 months ago by Lei Zhang
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Cleanup: Simplify some extension API code. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155890

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -25 lines) Patch
M chrome/browser/extensions/api/alarms/alarm_manager.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.h View 1 2 3 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.cc View 1 2 6 chunks +17 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Lei Zhang
8 years, 3 months ago (2012-09-07 22:44:24 UTC) #1
jochen (gone - plz use gerrit)
https://chromiumcodereview.appspot.com/10915153/diff/10001/chrome/browser/extensions/api/cookies/cookies_api.cc File chrome/browser/extensions/api/cookies/cookies_api.cc (right): https://chromiumcodereview.appspot.com/10915153/diff/10001/chrome/browser/extensions/api/cookies/cookies_api.cc#newcode66 chrome/browser/extensions/api/cookies/cookies_api.cc:66: if (!profile_->IsSameProfile(profile)) The incognito profile and the regular profile ...
8 years, 3 months ago (2012-09-10 08:31:27 UTC) #2
Lei Zhang
https://chromiumcodereview.appspot.com/10915153/diff/10001/chrome/browser/extensions/api/cookies/cookies_api.cc File chrome/browser/extensions/api/cookies/cookies_api.cc (right): https://chromiumcodereview.appspot.com/10915153/diff/10001/chrome/browser/extensions/api/cookies/cookies_api.cc#newcode66 chrome/browser/extensions/api/cookies/cookies_api.cc:66: if (!profile_->IsSameProfile(profile)) On 2012/09/10 08:31:27, jochen wrote: > The ...
8 years, 3 months ago (2012-09-10 17:55:12 UTC) #3
jochen (gone - plz use gerrit)
lgtm
8 years, 3 months ago (2012-09-10 19:35:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10915153/9002
8 years, 3 months ago (2012-09-10 20:37:51 UTC) #5
commit-bot: I haz the power
Try job failure for 10915153-9002 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 3 months ago (2012-09-10 22:28:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10915153/9002
8 years, 3 months ago (2012-09-10 22:32:51 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-11 01:02:45 UTC) #8
Change committed as 155890

Powered by Google App Engine
This is Rietveld 408576698