Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 10915146: Cleanup thumbnail database part #2 (Closed)

Created:
8 years, 3 months ago by pkotwicz
Modified:
8 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, browser-components-watch_chromium.org, michaelbai
Visibility:
Public.

Description

Pass in favicon sizes parameter to ThumbnailDatabase::AddFavicon(). Fix ThumbnailDatabase::GetIconMappingsForPageURL to have functionality described by the comment. Bug=10896006 Test=Try bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155540

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -96 lines) Patch
M chrome/browser/history/expire_history_backend_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 1 2 3 4 chunks +12 lines, -3 lines 0 comments Download
M chrome/browser/history/thumbnail_database.h View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/history/thumbnail_database.cc View 1 2 3 chunks +15 lines, -7 lines 0 comments Download
M chrome/browser/history/thumbnail_database_unittest.cc View 1 2 3 14 chunks +98 lines, -78 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pkotwicz
Scott, can you please take a look? Subpart of http://codereview.chromium.org/10917041
8 years, 3 months ago (2012-09-07 17:47:23 UTC) #1
sky
LGTM http://codereview.chromium.org/10915146/diff/2001/chrome/browser/history/history_backend_unittest.cc File chrome/browser/history/history_backend_unittest.cc (right): http://codereview.chromium.org/10915146/diff/2001/chrome/browser/history/history_backend_unittest.cc#newcode213 chrome/browser/history/history_backend_unittest.cc:213: CR_DEFINE_STATIC_LOCAL(std::vector<gfx::Size>, kSizesSmallAndLarge, ()); This is a test, there's ...
8 years, 3 months ago (2012-09-07 18:16:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10915146/7001
8 years, 3 months ago (2012-09-07 22:10:56 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-08 00:29:14 UTC) #4
Change committed as 155540

Powered by Google App Engine
This is Rietveld 408576698