Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: media/base/audio_fifo.h

Issue 10915123: Adds media::AudioPullFifo class to Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: AudioFIFO changes based on comments from Andrew Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/audio_fifo.cc » ('j') | media/base/audio_pull_fifo.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_fifo.h
diff --git a/media/base/audio_fifo.h b/media/base/audio_fifo.h
index 1215f9a16bffaa3f25fd0da7ac614e2a4b75af13..d56cd5f322b174b1ee4736189e134ec96da6317e 100644
--- a/media/base/audio_fifo.h
+++ b/media/base/audio_fifo.h
@@ -21,34 +21,34 @@ class MEDIA_EXPORT AudioFifo {
virtual ~AudioFifo();
// Pushes all audio channel data from |source| to the FIFO.
- // Returns false if the allocated space is not sufficient. Partial data is
- // not written to the FIFO for this overflow case.
- bool Push(const AudioBus* source);
+ // This call crash fail if the allocated space is not sufficient.
scherkus (not reviewing) 2012/09/07 14:19:03 s/This call crash fail/Push() will crash/?
henrika (OOO until Aug 14) 2012/09/10 07:23:04 Done.
+ void Push(const AudioBus* source);
// Consumes |frames_to_consume| audio frames from the FIFO and copies
// them to |destination|.
- // Returns false if the FIFO does not contain |frames_to_consume| frames
- // or if there is not sufficient space in |destination| to store the frames.
- bool Consume(AudioBus* destination, int frames_to_consume);
+ // This call will crash if the FIFO does not contain |frames_to_consume|
+ // frames or if there is not sufficient space in |destination| to store the
scherkus (not reviewing) 2012/09/07 14:19:03 ditto
henrika (OOO until Aug 14) 2012/09/10 07:23:04 Done.
+ // frames.
+ void Consume(AudioBus* destination, int frames_to_consume);
// Empties the FIFO without deallocating any memory.
void Clear();
// Number of actual audio frames in the FIFO.
- int frames_in_fifo() const { return frames_in_fifo_; }
+ int frames() const { return frames_; }
private:
- int max_frames() const { return max_frames_in_fifo_; }
+ int max_frames() const { return max_frames_; }
// The actual FIFO is an audio bus implemented as a ring buffer.
scoped_ptr<AudioBus> audio_bus_;
// Maximum number of elements the FIFO can contain.
// This value is set by |frames| in the constructor.
- const int max_frames_in_fifo_;
+ const int max_frames_;
// Number of actual elements in the FIFO.
- int frames_in_fifo_;
+ int frames_;
// Current read position.
int read_pos_;
« no previous file with comments | « no previous file | media/base/audio_fifo.cc » ('j') | media/base/audio_pull_fifo.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698