Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: lib/compiler/implementation/ssa/nodes.dart

Issue 10915122: Fix source locations for inlined and patched functions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/codegen.dart ('k') | tests/compiler/dart2js/source_mapping_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/nodes.dart
diff --git a/lib/compiler/implementation/ssa/nodes.dart b/lib/compiler/implementation/ssa/nodes.dart
index 9bc94642c53c4dfde6969db3f43f1302625a7e76..e63d937d402807e66e8993614d585e8afe603785 100644
--- a/lib/compiler/implementation/ssa/nodes.dart
+++ b/lib/compiler/implementation/ssa/nodes.dart
@@ -741,7 +741,7 @@ class HBasicBlock extends HInstructionList implements Hashable {
class HInstruction implements Hashable {
Element sourceElement;
- Token sourcePosition;
+ SourceFileLocation sourcePosition;
final int id;
static int idCounter;
@@ -2753,7 +2753,8 @@ class HLoopBlockInformation implements HStatementInformation {
final HExpressionInformation updates;
final TargetElement target;
final List<LabelElement> labels;
- final Node sourcePosition;
+ final SourceFileLocation sourcePosition;
+ final SourceFileLocation endSourcePosition;
HLoopBlockInformation(this.kind,
this.initializer,
@@ -2762,7 +2763,8 @@ class HLoopBlockInformation implements HStatementInformation {
this.updates,
this.target,
this.labels,
- this.sourcePosition);
+ this.sourcePosition,
+ this.endSourcePosition);
HBasicBlock get start {
if (initializer !== null) return initializer.start;
« no previous file with comments | « lib/compiler/implementation/ssa/codegen.dart ('k') | tests/compiler/dart2js/source_mapping_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698