In preparation for lazy deoptimization add "is_alive_" field to RawCode: visit embedded pointers on…

runtime/vm/raw_object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_RAW_OBJECT_H_
 #define VM_RAW_OBJECT_H_
 
 #include "platform/assert.h"
 #include "vm/globals.h"
 #include "vm/token.h"
@@ skipping 744 matching lines @@
   RawArray* deopt_info_array_;
   RawArray* object_table_;
   RawArray* stackmaps_;
   RawLocalVarDescriptors* var_descriptors_;
   RawArray* comments_;
   RawObject** to() {
     return reinterpret_cast<RawObject**>(&ptr()->comments_);
   }
 
   intptr_t pointer_offsets_length_;
-  // This cannot be boolean because of alignment issues on x64 architectures.
+  // These fields cannot be boolean because of alignment issues on x64
+  // architectures.
   intptr_t is_optimized_;
+  // If true, the embedded object pointers will be visited during GC.
+  intptr_t is_alive_;

[siva, 2012/09/06 16:57:55]

Not for this CL but at some point we should consider making these fields bit
fields (similar to what we have done with function, field etc.

[srdjan, 2012/09/06 17:06:03]

Agree.

 
   // Variable length data follows here.
   int32_t data_[0];
 
   friend class StackFrame;
 };
 
 
 class RawInstructions : public RawObject {
   RAW_HEAP_OBJECT_IMPLEMENTATION(Instructions);
@@ skipping 809 matching lines @@
          kExternalUint64ArrayCid == kByteArrayCid + 18 &&
          kExternalFloat32ArrayCid == kByteArrayCid + 19 &&
          kExternalFloat64ArrayCid == kByteArrayCid + 20 &&
          kStacktraceCid == kByteArrayCid + 21);
   return (index >= kByteArrayCid && index <= kExternalFloat64ArrayCid);
 }
 
 }  // namespace dart
 
 #endif  // VM_RAW_OBJECT_H_