Enable Media Source API by default.

Enable Media Source API by default.


BUG=144669
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155438

[darin (slow to review), 2012-09-06 19:01:54]

How do I learn more about the Media Source API?  Is there a meta bug for
it?  Are we releasing with the API vendor prefixed?  How likely is it to
change further?  Are you targeting M23?

-Darin



On Thu, Sep 6, 2012 at 12:50 AM, <acolwell@chromium.org> wrote:

> Reviewers: darin,
>
> Description:
> Enable Media Source API by default.
>
>
> BUG=144669
>
>
> Please review this at
http://codereview.chromium.**org/10915117/<http://codereview.chromium.org/109...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/app/generated_**resources.grd
>   M chrome/browser/about_flags.cc
>   M content/browser/renderer_host/**render_process_host_impl.cc
>   M content/public/common/content_**switches.h
>   M content/public/common/content_**switches.cc
>   M content/renderer/render_**thread_impl.cc
>
>
> Index: chrome/app/generated_**resources.grd
> diff --git a/chrome/app/generated_**resources.grd b/chrome/app/generated_*
> *resources.grd
> index 40c3f5124235e6065a92d190f5f286**7c737dfff6..**
> 8b155c410b96137d250574e59f1487**98af70b7f2 100644
> --- a/chrome/app/generated_**resources.grd
> +++ b/chrome/app/generated_**resources.grd
> @@ -6011,11 +6011,11 @@ Keep your key file in a safe place. You will need
> it to create new versions of y
>        <message name="IDS_FLAGS_ENABLE_**EXTENSION_ALERTS_DESCRIPTION"
> desc="Description for the flag to enable extension alerts.">
>          Enable various alerts about changes in extension state.
>        </message>
> -      <message name="IDS_FLAGS_ENABLE_MEDIA_**SOURCE_NAME" desc="Title
> for the flag to enable the Media Source API on &lt;video&gt; elements.">
> -        Enable Media Source API on <ph
name="VIDEO_HTML">&lt;video&**gt;<ex>&lt;video&gt;</ex></ph>
> elements.
> +      <message name="IDS_FLAGS_DISABLE_MEDIA_**SOURCE_NAME" desc="Title
> for the flag to disable the Media Source API on &lt;video&gt; elements.">
> +        Disable Media Source API on <ph
name="VIDEO_HTML">&lt;video&**gt;<ex>&lt;video&gt;</ex></ph>
> elements.
>        </message>
> -      <message name="IDS_FLAGS_ENABLE_MEDIA_**SOURCE_DESCRIPTION"
> desc="Description for the flag to enable the Media Source API on
> &lt;video&gt; elements.">
> -        Enable experimental Media Source API on the video elements. This
> API allows JavaScript to send media data directly to a video element.
> +      <message name="IDS_FLAGS_DISABLE_MEDIA_**SOURCE_DESCRIPTION"
> desc="Description for the flag to disable the Media Source API on
> &lt;video&gt; elements.">
> +        Disable experimental Media Source API on the video elements. This
> API allows JavaScript to send media data directly to a video element.
>        </message>
>        <message name="IDS_FLAGS_ENABLE_**ENCRYPTED_MEDIA_NAME"
> desc="Title for the flag to enable the Encrypted Media Extensions on
> &lt;video&gt; elements.">
>          Enable Encrypted Media Extensions on <ph
> name="VIDEO_HTML">&lt;video&**gt;<ex>&lt;video&gt;</ex></ph> elements.
> Index: chrome/browser/about_flags.cc
> diff --git a/chrome/browser/about_flags.**cc b/chrome/browser/about_flags.
> **cc
> index 31a34b0744d4c614094b98a7ccc963**db56c99405..**
> 66854cbfcfba484822c5d1443a12fb**47c84aea48 100644
> --- a/chrome/browser/about_flags.**cc
> +++ b/chrome/browser/about_flags.**cc
> @@ -542,10 +542,10 @@ const Experiment kExperiments[] = {
>    },
>    {
>      "enable-media-source",
> -    IDS_FLAGS_ENABLE_MEDIA_SOURCE_**NAME,
> -    IDS_FLAGS_ENABLE_MEDIA_SOURCE_**DESCRIPTION,
> +    IDS_FLAGS_DISABLE_MEDIA_**SOURCE_NAME,
> +    IDS_FLAGS_DISABLE_MEDIA_**SOURCE_DESCRIPTION,
>      kOsAll,
> -    SINGLE_VALUE_TYPE(switches::**kEnableMediaSource)
> +    SINGLE_VALUE_TYPE(switches::**kDisableMediaSource)
>    },
>    {
>      "enable-encrypted-media",
> Index: content/browser/renderer_host/**render_process_host_impl.cc
> diff --git a/content/browser/renderer_**host/render_process_host_impl.**cc
> b/content/browser/renderer_**host/render_process_host_impl.**cc
> index 696a3db146426b4557dc7a0813eb05**2bc869aeb2..**
> b6b098271f554c266a4d1fcfbc3619**899f015b7e 100644
> --- a/content/browser/renderer_**host/render_process_host_impl.**cc
> +++ b/content/browser/renderer_**host/render_process_host_impl.**cc
> @@ -771,7 +771,7 @@ void RenderProcessHostImpl::**
> PropagateBrowserCommandLineToR**enderer(
>      switches::**kEnableGPUClientLogging,
>      switches::**kEnableGpuBenchmarking,
>      switches::kEnableLogging,
> -    switches::kEnableMediaSource,
> +    switches::kDisableMediaSource,
>      switches::kEnablePartialSwap,
>      switches::**kEnablePerTilePainting,
>      switches::**kEnableRendererSideMixing,
> Index: content/public/common/content_**switches.cc
> diff --git a/content/public/common/**content_switches.cc
> b/content/public/common/**content_switches.cc
> index 6db3e8db0b5493363745db1fb21f0b**cccef6cb64..**
> 80dc271a7513a1b3beb433571ca0cd**454849ab98 100644
> --- a/content/public/common/**content_switches.cc
> +++ b/content/public/common/**content_switches.cc
> @@ -304,8 +304,8 @@ const char kEnableGpuBenchmarking[]         =
> "enable-gpu-benchmarking";
>  // builds.
>  const char kEnableLogging[]                 = "enable-logging";
>
> -// Enables Media Source API on <audio>/<video> elements.
> -const char kEnableMediaSource[]             = "enable-media-source";
> +// Disable Media Source API on <audio>/<video> elements.
> +const char kDisableMediaSource[]             = "disable-media-source";
>
>  // On Windows, converts the page to the currently-installed monitor
> profile.
>  // This does NOT enable color management for images. The source is still
> Index: content/public/common/content_**switches.h
> diff --git a/content/public/common/**content_switches.h
> b/content/public/common/**content_switches.h
> index aac9514e4890d47904d8721a701ef6**21d375af6c..**
> 692d9d7737925728769b26d668960f**895bc8f76f 100644
> --- a/content/public/common/**content_switches.h
> +++ b/content/public/common/**content_switches.h
> @@ -108,7 +108,7 @@ CONTENT_EXPORT extern const char kDisableFullScreen[];
>  extern const char kEnablePointerLock[];
>  extern const char kEnableGpuBenchmarking[];
>  CONTENT_EXPORT extern const char kEnableLogging[];
> -extern const char kEnableMediaSource[];
> +extern const char kDisableMediaSource[];
>  extern const char kEnableMonitorProfile[];
>  extern const char kEnablePartialSwap[];
>  extern const char kEnableUIReleaseFrontSurface[]**;
> Index: content/renderer/render_**thread_impl.cc
> diff --git a/content/renderer/render_**thread_impl.cc
> b/content/renderer/render_**thread_impl.cc
> index 8f9bb72bccdbf9578fc197063fa1cf**088a513ab0..**
> c85d15d32e1246d05d08febbd5a00d**4eed616682 100644
> --- a/content/renderer/render_**thread_impl.cc
> +++ b/content/renderer/render_**thread_impl.cc
> @@ -654,7 +654,7 @@ void RenderThreadImpl::**EnsureWebKitInitialized() {
>        !command_line.HasSwitch(**switches::kDisableGeolocation)**);
>
>    WebKit::WebRuntimeFeatures::**enableMediaSource(
> -      command_line.HasSwitch(**switches::kEnableMediaSource))**;
> +      !command_line.HasSwitch(**switches::kDisableMediaSource)**);
>
>    WebRuntimeFeatures::**enableMediaPlayer(
>        media::**IsMediaLibraryInitialized());
>
>
>

[acolwell GONE FROM CHROMIUM, 2012-09-06 21:18:39]

Hi Darin,

The Media Source Extensions
spec<http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html>
is
currently a W3C Editor's draft that is being developed in the HTML-WG. The
Chrome implementation of this API is vendor prefixed. The current
implementation contains everything in the current version of the spec and
the signatures of the methods and the attribute names are not likely to
change. There are several open
bugs<https://www.w3.org/Bugs/Public/buglist.cgi?product=HTML%20WG&component=Media%20Source%20Extensions>
against
the spec, most of which are clarifications on behavior. There are a few
"new feature" bugs, but those will likely just add new methods, attributes,
or events and should not change existing functionality. We are targeting
M23 which is why I'm trying to land this now. There isn't a metabug for
this.

Aaron

Aaron


On Thu, Sep 6, 2012 at 9:01 PM, Darin Fisher <darin@chromium.org> wrote:

> How do I learn more about the Media Source API?  Is there a meta bug for
> it?  Are we releasing with the API vendor prefixed?  How likely is it to
> change further?  Are you targeting M23?
>
> -Darin
>
>
>
> On Thu, Sep 6, 2012 at 12:50 AM, <acolwell@chromium.org> wrote:
>
>> Reviewers: darin,
>>
>> Description:
>> Enable Media Source API by default.
>>
>>
>> BUG=144669
>>
>>
>> Please review this at
http://codereview.chromium.**org/10915117/<http://codereview.chromium.org/109...
>>
>> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>>
>> Affected files:
>>   M chrome/app/generated_**resources.grd
>>   M chrome/browser/about_flags.cc
>>   M content/browser/renderer_host/**render_process_host_impl.cc
>>   M content/public/common/content_**switches.h
>>   M content/public/common/content_**switches.cc
>>   M content/renderer/render_**thread_impl.cc
>>
>>
>> Index: chrome/app/generated_**resources.grd
>> diff --git a/chrome/app/generated_**resources.grd b/chrome/app/generated_
>> **resources.grd
>> index 40c3f5124235e6065a92d190f5f286**7c737dfff6..**
>> 8b155c410b96137d250574e59f1487**98af70b7f2 100644
>> --- a/chrome/app/generated_**resources.grd
>> +++ b/chrome/app/generated_**resources.grd
>> @@ -6011,11 +6011,11 @@ Keep your key file in a safe place. You will need
>> it to create new versions of y
>>        <message name="IDS_FLAGS_ENABLE_**EXTENSION_ALERTS_DESCRIPTION"
>> desc="Description for the flag to enable extension alerts.">
>>          Enable various alerts about changes in extension state.
>>        </message>
>> -      <message name="IDS_FLAGS_ENABLE_MEDIA_**SOURCE_NAME" desc="Title
>> for the flag to enable the Media Source API on &lt;video&gt; elements.">
>> -        Enable Media Source API on <ph
name="VIDEO_HTML">&lt;video&**gt;<ex>&lt;video&gt;</ex></ph>
>> elements.
>> +      <message name="IDS_FLAGS_DISABLE_MEDIA_**SOURCE_NAME" desc="Title
>> for the flag to disable the Media Source API on &lt;video&gt; elements.">
>> +        Disable Media Source API on <ph
name="VIDEO_HTML">&lt;video&**gt;<ex>&lt;video&gt;</ex></ph>
>> elements.
>>        </message>
>> -      <message name="IDS_FLAGS_ENABLE_MEDIA_**SOURCE_DESCRIPTION"
>> desc="Description for the flag to enable the Media Source API on
>> &lt;video&gt; elements.">
>> -        Enable experimental Media Source API on the video elements. This
>> API allows JavaScript to send media data directly to a video element.
>> +      <message name="IDS_FLAGS_DISABLE_MEDIA_**SOURCE_DESCRIPTION"
>> desc="Description for the flag to disable the Media Source API on
>> &lt;video&gt; elements.">
>> +        Disable experimental Media Source API on the video elements.
>> This API allows JavaScript to send media data directly to a video element.
>>        </message>
>>        <message name="IDS_FLAGS_ENABLE_**ENCRYPTED_MEDIA_NAME"
>> desc="Title for the flag to enable the Encrypted Media Extensions on
>> &lt;video&gt; elements.">
>>          Enable Encrypted Media Extensions on <ph
>> name="VIDEO_HTML">&lt;video&**gt;<ex>&lt;video&gt;</ex></ph> elements.
>> Index: chrome/browser/about_flags.cc
>> diff --git a/chrome/browser/about_flags.**cc
>> b/chrome/browser/about_flags.**cc
>> index 31a34b0744d4c614094b98a7ccc963**db56c99405..**
>> 66854cbfcfba484822c5d1443a12fb**47c84aea48 100644
>> --- a/chrome/browser/about_flags.**cc
>> +++ b/chrome/browser/about_flags.**cc
>> @@ -542,10 +542,10 @@ const Experiment kExperiments[] = {
>>    },
>>    {
>>      "enable-media-source",
>> -    IDS_FLAGS_ENABLE_MEDIA_SOURCE_**NAME,
>> -    IDS_FLAGS_ENABLE_MEDIA_SOURCE_**DESCRIPTION,
>> +    IDS_FLAGS_DISABLE_MEDIA_**SOURCE_NAME,
>> +    IDS_FLAGS_DISABLE_MEDIA_**SOURCE_DESCRIPTION,
>>      kOsAll,
>> -    SINGLE_VALUE_TYPE(switches::**kEnableMediaSource)
>> +    SINGLE_VALUE_TYPE(switches::**kDisableMediaSource)
>>    },
>>    {
>>      "enable-encrypted-media",
>> Index: content/browser/renderer_host/**render_process_host_impl.cc
>> diff --git a/content/browser/renderer_**host/render_process_host_impl.**cc
>> b/content/browser/renderer_**host/render_process_host_impl.**cc
>> index 696a3db146426b4557dc7a0813eb05**2bc869aeb2..**
>> b6b098271f554c266a4d1fcfbc3619**899f015b7e 100644
>> --- a/content/browser/renderer_**host/render_process_host_impl.**cc
>> +++ b/content/browser/renderer_**host/render_process_host_impl.**cc
>> @@ -771,7 +771,7 @@ void RenderProcessHostImpl::**
>> PropagateBrowserCommandLineToR**enderer(
>>      switches::**kEnableGPUClientLogging,
>>      switches::**kEnableGpuBenchmarking,
>>      switches::kEnableLogging,
>> -    switches::kEnableMediaSource,
>> +    switches::kDisableMediaSource,
>>      switches::kEnablePartialSwap,
>>      switches::**kEnablePerTilePainting,
>>      switches::**kEnableRendererSideMixing,
>> Index: content/public/common/content_**switches.cc
>> diff --git a/content/public/common/**content_switches.cc
>> b/content/public/common/**content_switches.cc
>> index 6db3e8db0b5493363745db1fb21f0b**cccef6cb64..**
>> 80dc271a7513a1b3beb433571ca0cd**454849ab98 100644
>> --- a/content/public/common/**content_switches.cc
>> +++ b/content/public/common/**content_switches.cc
>> @@ -304,8 +304,8 @@ const char kEnableGpuBenchmarking[]         =
>> "enable-gpu-benchmarking";
>>  // builds.
>>  const char kEnableLogging[]                 = "enable-logging";
>>
>> -// Enables Media Source API on <audio>/<video> elements.
>> -const char kEnableMediaSource[]             = "enable-media-source";
>> +// Disable Media Source API on <audio>/<video> elements.
>> +const char kDisableMediaSource[]             = "disable-media-source";
>>
>>  // On Windows, converts the page to the currently-installed monitor
>> profile.
>>  // This does NOT enable color management for images. The source is still
>> Index: content/public/common/content_**switches.h
>> diff --git a/content/public/common/**content_switches.h
>> b/content/public/common/**content_switches.h
>> index aac9514e4890d47904d8721a701ef6**21d375af6c..**
>> 692d9d7737925728769b26d668960f**895bc8f76f 100644
>> --- a/content/public/common/**content_switches.h
>> +++ b/content/public/common/**content_switches.h
>> @@ -108,7 +108,7 @@ CONTENT_EXPORT extern const char kDisableFullScreen[];
>>  extern const char kEnablePointerLock[];
>>  extern const char kEnableGpuBenchmarking[];
>>  CONTENT_EXPORT extern const char kEnableLogging[];
>> -extern const char kEnableMediaSource[];
>> +extern const char kDisableMediaSource[];
>>  extern const char kEnableMonitorProfile[];
>>  extern const char kEnablePartialSwap[];
>>  extern const char kEnableUIReleaseFrontSurface[]**;
>> Index: content/renderer/render_**thread_impl.cc
>> diff --git a/content/renderer/render_**thread_impl.cc
>> b/content/renderer/render_**thread_impl.cc
>> index 8f9bb72bccdbf9578fc197063fa1cf**088a513ab0..**
>> c85d15d32e1246d05d08febbd5a00d**4eed616682 100644
>> --- a/content/renderer/render_**thread_impl.cc
>> +++ b/content/renderer/render_**thread_impl.cc
>> @@ -654,7 +654,7 @@ void RenderThreadImpl::**EnsureWebKitInitialized() {
>>        !command_line.HasSwitch(**switches::kDisableGeolocation)**);
>>
>>    WebKit::WebRuntimeFeatures::**enableMediaSource(
>> -      command_line.HasSwitch(**switches::kEnableMediaSource))**;
>> +      !command_line.HasSwitch(**switches::kDisableMediaSource)**);
>>
>>    WebRuntimeFeatures::**enableMediaPlayer(
>>        media::**IsMediaLibraryInitialized());
>>
>>
>>
>

[darin (slow to review), 2012-09-07 03:29:42]

LGTM

Please understand that by shipping a vendor prefixed feature, you are on
the hook for supporting the API that you have snapshotted.  It sounds like
this is clear, and you don't anticipate conflicts down the road, but I just
want to emphasize the point.

-Darin



On Thu, Sep 6, 2012 at 2:18 PM, Aaron Colwell <acolwell@chromium.org> wrote:

> Hi Darin,
>
> The Media Source Extensions
spec<http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html>
is
> currently a W3C Editor's draft that is being developed in the HTML-WG. The
> Chrome implementation of this API is vendor prefixed. The current
> implementation contains everything in the current version of the spec and
> the signatures of the methods and the attribute names are not likely to
> change. There are several open
bugs<https://www.w3.org/Bugs/Public/buglist.cgi?product=HTML%20WG&component=Media%20Source%20Extensions>
against
> the spec, most of which are clarifications on behavior. There are a few
> "new feature" bugs, but those will likely just add new methods, attributes,
> or events and should not change existing functionality. We are targeting
> M23 which is why I'm trying to land this now. There isn't a metabug for
> this.
>
> Aaron
>
> Aaron
>
>
> On Thu, Sep 6, 2012 at 9:01 PM, Darin Fisher <darin@chromium.org> wrote:
>
>> How do I learn more about the Media Source API?  Is there a meta bug for
>> it?  Are we releasing with the API vendor prefixed?  How likely is it to
>> change further?  Are you targeting M23?
>>
>> -Darin
>>
>>
>>
>> On Thu, Sep 6, 2012 at 12:50 AM, <acolwell@chromium.org> wrote:
>>
>>> Reviewers: darin,
>>>
>>> Description:
>>> Enable Media Source API by default.
>>>
>>>
>>> BUG=144669
>>>
>>>
>>> Please review this at
http://codereview.chromium.**org/10915117/<http://codereview.chromium.org/109...
>>>
>>> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>>>
>>> Affected files:
>>>   M chrome/app/generated_**resources.grd
>>>   M chrome/browser/about_flags.cc
>>>   M content/browser/renderer_host/**render_process_host_impl.cc
>>>   M content/public/common/content_**switches.h
>>>   M content/public/common/content_**switches.cc
>>>   M content/renderer/render_**thread_impl.cc
>>>
>>>
>>> Index: chrome/app/generated_**resources.grd
>>> diff --git a/chrome/app/generated_**resources.grd
>>> b/chrome/app/generated_**resources.grd
>>> index 40c3f5124235e6065a92d190f5f286**7c737dfff6..**
>>> 8b155c410b96137d250574e59f1487**98af70b7f2 100644
>>> --- a/chrome/app/generated_**resources.grd
>>> +++ b/chrome/app/generated_**resources.grd
>>> @@ -6011,11 +6011,11 @@ Keep your key file in a safe place. You will
>>> need it to create new versions of y
>>>        <message name="IDS_FLAGS_ENABLE_**EXTENSION_ALERTS_DESCRIPTION"
>>> desc="Description for the flag to enable extension alerts.">
>>>          Enable various alerts about changes in extension state.
>>>        </message>
>>> -      <message name="IDS_FLAGS_ENABLE_MEDIA_**SOURCE_NAME" desc="Title
>>> for the flag to enable the Media Source API on &lt;video&gt; elements.">
>>> -        Enable Media Source API on <ph
name="VIDEO_HTML">&lt;video&**gt;<ex>&lt;video&gt;</ex></ph>
>>> elements.
>>> +      <message name="IDS_FLAGS_DISABLE_MEDIA_**SOURCE_NAME"
>>> desc="Title for the flag to disable the Media Source API on &lt;video&gt;
>>> elements.">
>>> +        Disable Media Source API on <ph
name="VIDEO_HTML">&lt;video&**gt;<ex>&lt;video&gt;</ex></ph>
>>> elements.
>>>        </message>
>>> -      <message name="IDS_FLAGS_ENABLE_MEDIA_**SOURCE_DESCRIPTION"
>>> desc="Description for the flag to enable the Media Source API on
>>> &lt;video&gt; elements.">
>>> -        Enable experimental Media Source API on the video elements.
>>> This API allows JavaScript to send media data directly to a video element.
>>> +      <message name="IDS_FLAGS_DISABLE_MEDIA_**SOURCE_DESCRIPTION"
>>> desc="Description for the flag to disable the Media Source API on
>>> &lt;video&gt; elements.">
>>> +        Disable experimental Media Source API on the video elements.
>>> This API allows JavaScript to send media data directly to a video element.
>>>        </message>
>>>        <message name="IDS_FLAGS_ENABLE_**ENCRYPTED_MEDIA_NAME"
>>> desc="Title for the flag to enable the Encrypted Media Extensions on
>>> &lt;video&gt; elements.">
>>>          Enable Encrypted Media Extensions on <ph
>>> name="VIDEO_HTML">&lt;video&**gt;<ex>&lt;video&gt;</ex></ph> elements.
>>> Index: chrome/browser/about_flags.cc
>>> diff --git a/chrome/browser/about_flags.**cc
>>> b/chrome/browser/about_flags.**cc
>>> index 31a34b0744d4c614094b98a7ccc963**db56c99405..**
>>> 66854cbfcfba484822c5d1443a12fb**47c84aea48 100644
>>> --- a/chrome/browser/about_flags.**cc
>>> +++ b/chrome/browser/about_flags.**cc
>>> @@ -542,10 +542,10 @@ const Experiment kExperiments[] = {
>>>    },
>>>    {
>>>      "enable-media-source",
>>> -    IDS_FLAGS_ENABLE_MEDIA_SOURCE_**NAME,
>>> -    IDS_FLAGS_ENABLE_MEDIA_SOURCE_**DESCRIPTION,
>>> +    IDS_FLAGS_DISABLE_MEDIA_**SOURCE_NAME,
>>> +    IDS_FLAGS_DISABLE_MEDIA_**SOURCE_DESCRIPTION,
>>>      kOsAll,
>>> -    SINGLE_VALUE_TYPE(switches::**kEnableMediaSource)
>>> +    SINGLE_VALUE_TYPE(switches::**kDisableMediaSource)
>>>    },
>>>    {
>>>      "enable-encrypted-media",
>>> Index: content/browser/renderer_host/**render_process_host_impl.cc
>>> diff --git a/content/browser/renderer_**host/render_process_host_impl.**cc
>>> b/content/browser/renderer_**host/render_process_host_impl.**cc
>>> index 696a3db146426b4557dc7a0813eb05**2bc869aeb2..**
>>> b6b098271f554c266a4d1fcfbc3619**899f015b7e 100644
>>> --- a/content/browser/renderer_**host/render_process_host_impl.**cc
>>> +++ b/content/browser/renderer_**host/render_process_host_impl.**cc
>>> @@ -771,7 +771,7 @@ void RenderProcessHostImpl::**
>>> PropagateBrowserCommandLineToR**enderer(
>>>      switches::**kEnableGPUClientLogging,
>>>      switches::**kEnableGpuBenchmarking,
>>>      switches::kEnableLogging,
>>> -    switches::kEnableMediaSource,
>>> +    switches::kDisableMediaSource,
>>>      switches::kEnablePartialSwap,
>>>      switches::**kEnablePerTilePainting,
>>>      switches::**kEnableRendererSideMixing,
>>> Index: content/public/common/content_**switches.cc
>>> diff --git a/content/public/common/**content_switches.cc
>>> b/content/public/common/**content_switches.cc
>>> index 6db3e8db0b5493363745db1fb21f0b**cccef6cb64..**
>>> 80dc271a7513a1b3beb433571ca0cd**454849ab98 100644
>>> --- a/content/public/common/**content_switches.cc
>>> +++ b/content/public/common/**content_switches.cc
>>> @@ -304,8 +304,8 @@ const char kEnableGpuBenchmarking[]         =
>>> "enable-gpu-benchmarking";
>>>  // builds.
>>>  const char kEnableLogging[]                 = "enable-logging";
>>>
>>> -// Enables Media Source API on <audio>/<video> elements.
>>> -const char kEnableMediaSource[]             = "enable-media-source";
>>> +// Disable Media Source API on <audio>/<video> elements.
>>> +const char kDisableMediaSource[]             = "disable-media-source";
>>>
>>>  // On Windows, converts the page to the currently-installed monitor
>>> profile.
>>>  // This does NOT enable color management for images. The source is still
>>> Index: content/public/common/content_**switches.h
>>> diff --git a/content/public/common/**content_switches.h
>>> b/content/public/common/**content_switches.h
>>> index aac9514e4890d47904d8721a701ef6**21d375af6c..**
>>> 692d9d7737925728769b26d668960f**895bc8f76f 100644
>>> --- a/content/public/common/**content_switches.h
>>> +++ b/content/public/common/**content_switches.h
>>> @@ -108,7 +108,7 @@ CONTENT_EXPORT extern const char
>>> kDisableFullScreen[];
>>>  extern const char kEnablePointerLock[];
>>>  extern const char kEnableGpuBenchmarking[];
>>>  CONTENT_EXPORT extern const char kEnableLogging[];
>>> -extern const char kEnableMediaSource[];
>>> +extern const char kDisableMediaSource[];
>>>  extern const char kEnableMonitorProfile[];
>>>  extern const char kEnablePartialSwap[];
>>>  extern const char kEnableUIReleaseFrontSurface[]**;
>>> Index: content/renderer/render_**thread_impl.cc
>>> diff --git a/content/renderer/render_**thread_impl.cc
>>> b/content/renderer/render_**thread_impl.cc
>>> index 8f9bb72bccdbf9578fc197063fa1cf**088a513ab0..**
>>> c85d15d32e1246d05d08febbd5a00d**4eed616682 100644
>>> --- a/content/renderer/render_**thread_impl.cc
>>> +++ b/content/renderer/render_**thread_impl.cc
>>> @@ -654,7 +654,7 @@ void RenderThreadImpl::**EnsureWebKitInitialized() {
>>>        !command_line.HasSwitch(**switches::kDisableGeolocation)**);
>>>
>>>    WebKit::WebRuntimeFeatures::**enableMediaSource(
>>> -      command_line.HasSwitch(**switches::kEnableMediaSource))**;
>>> +      !command_line.HasSwitch(**switches::kDisableMediaSource)**);
>>>
>>>    WebRuntimeFeatures::**enableMediaPlayer(
>>>        media::**IsMediaLibraryInitialized());
>>>
>>>
>>>
>>
>

[commit-bot: I haz the power, 2012-09-07 08:32:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/10915117/2003

[commit-bot: I haz the power, 2012-09-07 10:30:20]

Try job failure for 10915117-2003 (retry) on mac_rel for step
"sync_integration_tests".
It's a second try, previously, step "sync_integration_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-09-07 16:26:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/10915117/2003

[commit-bot: I haz the power, 2012-09-07 18:56:13]

Change committed as 155438