Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder_unittest.py

Issue 10915114: chrome_remote_control: Fix osx browser discovery (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Tweaks Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder_unittest.py
diff --git a/tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder_unittest.py b/tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder_unittest.py
index ed580a593304552ed5061b6aeae041a881ac62fb..b82ee9ad31b2bb8f13e73dd0e048edd9b1f05cd9 100644
--- a/tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder_unittest.py
+++ b/tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder_unittest.py
@@ -93,22 +93,22 @@ class OSXFindTest(FindTestBase):
"Contents/MacOS/Google Chrome Canary")
self._files.append("/Applications/Google Chrome.app/" +
"Contents/MacOS/Google Chrome")
-
- def testFindCanaryWithBothPresent(self):
+ self._files.append(
+ "../../../out/Release/Chromium.app/Contents/MacOS/Chromium")
+ self._files.append(
+ "../../../out/Debug/Chromium.app/Contents/MacOS/Chromium")
+ self._files.append(
+ "../../../out/Release/Content Shell.app/Contents/MacOS/Content Shell")
+ self._files.append(
+ "../../../out/Debug/Content Shell.app/Contents/MacOS/Content Shell")
+
+ def testFindAll(self):
types = self.DoFindAllTypes()
- assert 'canary' in types
- assert 'system' in types
- assert len(types) == 2
-
- def testFind(self):
- browsers = self.DoFindAll()
- self.assertTrue(has_type(browsers, 'canary'))
- self.assertTrue(has_type(browsers, 'system'))
-
- del self._files[0]
- browsers = self.DoFindAll()
- self.assertFalse(has_type(browsers, 'canary'))
- self.assertTrue(has_type(browsers, 'system'))
+ self.assertEquals(
+ set(types),
+ set(['debug', 'release',
+ 'content-shell-debug', 'content-shell-release',
+ 'canary', 'system']))
class LinuxFindTest(FindTestBase):
« no previous file with comments | « tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698