tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py - Issue 10915114: chrome_remote_control: Fix osx browser discovery

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py

Issue 10915114: chrome_remote_control: Fix osx browser discovery (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Tweaks Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/chrome_remote_control/chrome_remote_control/browser_options.py ('k') | tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py

diff --git a/tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py b/tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py

index 712dc0777847dcdde46d5586488c5338dc048d30..963db37218a8f999443b8d69808f529041dd111f 100644

--- a/tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py

+++ b/tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py

@@ -39,7 +39,7 @@ class DesktopBrowserBackend(browser_backend.BrowserBackend):

self._tmpdir = tempfile.mkdtemp()

args.append("--user-data-dir=%s" % self._tmpdir)

args.extend(options.extra_browser_args)

- if options.hide_stdout:

+ if not options.show_stdout:

self._devnull = open(os.devnull, 'w')

self._proc = subprocess.Popen(

args,stdout=self._devnull, stderr=self._devnull)