Renaming instances of "flimflam" with "shill", now that we're only

Renaming instances of "flimflam" with "shill", now that we're only using shill.

Does not rename things from the flimflam:: namespace in service_constants.h: that will be saved for a later pass.

I think this counts as refactoring, so I'm TBR'ing the OWNERS checks.

TBR=zelidrag@chromium.org,glotov@chromium.org
BUG=chromium:146616
TEST=built and ran


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155477

[Mattias Nissler (ping if slow), 2012-09-06 11:20:36]

I took a cursory look and assuming this is just s/flimflam/shill/, rubber-stamp
LGTM.

Adding pneubeck to take a look as well.

[Mattias Nissler (ping if slow), 2012-09-06 11:28:35]

On 2012/09/06 11:20:36, Mattias Nissler wrote:
> I took a cursory look and assuming this is just s/flimflam/shill/,
rubber-stamp
> LGTM.
> 
> Adding pneubeck to take a look as well.

FWIW:

$ grep -ri flimflam chrome | grep -v flimflam::
chrome/test/pyautolib/pyauto.py:    vaults or flimflam profiles left over by
previous tests can be cleared by
chrome/test/pyautolib/pyauto.py:    calling RemoveAllCryptohomeVaults()
respectively CleanFlimflamDirs() before
chrome/test/pyautolib/pyauto.py:    logging in to improve isolation. Note that
clearing flimflam profiles
chrome/test/pyautolib/pyauto.py:    requires a flimflam restart, briefly taking
down network connectivity and
chrome/test/pyautolib/pyauto.py:    slowing down the test. This should be done
for tests that use flimflam only.
chrome/test/pyautolib/pyauto.py:      if item not in ['log', 'flimflam'] and not
item.startswith('.'):
chrome/test/pyautolib/pyauto.py:  def CleanupFlimflamDirsOnChromeOS():
chrome/test/pyautolib/pyauto.py:    """Clean the contents of flimflam profiles
and restart flimflam."""
chrome/test/pyautolib/pyauto.py:   
PyUITest.RunSuperuserActionOnChromeOS('CleanFlimflamDirs')
chrome/test/pyautolib/pyauto.py:    but keeping the the wired ethernet interface
up and faking shill/flimflam
chrome/test/pyautolib/pyauto.py:      service_path: Flimflam path that defines
the remembered network.
chrome/test/pyautolib/pyauto.py:      service_path: Flimflam path that defines
the wifi network.
chrome/test/pyautolib/chromeos_network.py:  A subclass of PyUITest that
automatically sets the flimflam
chrome/test/pyautolib/chromeos_network.py:  _FLIMFLAM_PATH =
'org.chromium.flimflam'
chrome/test/pyautolib/chromeos_network.py:   
self.CleanupFlimflamDirsOnChromeOS()
chrome/test/pyautolib/chromeos_network.py:    # Move ethernet to the end of the
flimflam priority list,
chrome/test/pyautolib/chromeos_network.py:  def _GetFlimflamManager(self):
chrome/test/pyautolib/chromeos_network.py:    _proxy =
dbus.SystemBus().get_object(self._FLIMFLAM_PATH, '/')
chrome/test/pyautolib/chromeos_network.py:    return dbus.Interface(_proxy,
self._FLIMFLAM_PATH + '.Manager')
chrome/test/pyautolib/chromeos_network.py:   
self._GetFlimflamManager().SetServiceOrder(service_order)
chrome/test/pyautolib/chromeos_network.py:    # Flimflam throws a dbus exception
if device is already disabled.  This
chrome/test/pyautolib/chromeos_network.py:     
self._GetFlimflamManager().DisableTechnology('wifi')
chrome/test/pyautolib/chromeos_network.py:      if
'org.chromium.flimflam.Error.AlreadyDisabled' not in str(e):
chrome/test/pyautolib/chromeos_network.py:   
self._GetFlimflamManager().EnableTechnology('wifi')
chrome/test/pyautolib/chromeos_network.py:    self._old_service_order =
self._GetFlimflamManager().GetServiceOrder()
chrome/test/pyautolib/chromeos_network.py:    set_service_order =
self._GetFlimflamManager().GetServiceOrder().split(',')
chrome/test/pyautolib/chromeos_network.py:        'Flimflam service order not
set properly. %s != %s' % \
chrome/test/pyautolib/chromeos_network.py:    set_service_order =
self._GetFlimflamManager().GetServiceOrder().split(',')
chrome/test/pyautolib/chromeos_network.py:        'Flimflam service order not
set properly. %s != %s' % \
chrome/test/pyautolib/chromeos/suid_actions.py:  sudo python suid_actions.py
--action=CleanFlimflamDirs
chrome/test/pyautolib/chromeos/suid_actions.py:  def CleanFlimflamDirs(self):
chrome/test/pyautolib/chromeos/suid_actions.py:    """Clean the contents of all
connection manager (shill/flimflam) profiles.
chrome/test/pyautolib/chromeos/suid_actions.py:    flimflam_dirs =
['/home/chronos/user/flimflam',
chrome/test/pyautolib/chromeos/suid_actions.py:                    
'/var/cache/flimflam',
chrome/test/pyautolib/chromeos/suid_actions.py:    # The stop/start flimflam
command should stop/start shill respectivly if
chrome/test/pyautolib/chromeos/suid_actions.py:    os.system('stop flimflam')
chrome/test/pyautolib/chromeos/suid_actions.py:      for flimflam_dir in
flimflam_dirs:
chrome/test/pyautolib/chromeos/suid_actions.py:        if not
os.path.exists(flimflam_dir):
chrome/test/pyautolib/chromeos/suid_actions.py:        for item in
os.listdir(flimflam_dir):
chrome/test/pyautolib/chromeos/suid_actions.py:          path =
os.path.join(flimflam_dir, item)
chrome/test/pyautolib/chromeos/suid_actions.py:      os.system('start flimflam')
chrome/test/pyautolib/chromeos/suid_actions.py:      # flimflam/shill is fully
initialized and accessible via DBus again.
chrome/test/pyautolib/chromeos/suid_actions.py:      # flimflam/shill may fail.
Until this is fixed, waiting for the
chrome/test/pyautolib/chromeos/suid_actions.py:          raise
RuntimeError('Timeout while waiting for flimflam/shill start.')
chrome/test/pyautolib/chromeos/suid_actions.py:    subprocess.call(['stop',
'flimflam'])
chrome/test/pyautolib/chromeos/suid_actions.py:    subprocess.call(['start',
'flimflam'])
chrome/test/functional/chromeos_gsm_compliance.py:    sub.call(['sudo',
'/bin/sh', '/usr/local/lib/flimflam/test/backchannel',
chrome/test/functional/chromeos_gsm_compliance.py:      sub.call(['sudo',
'/bin/sh', '/usr/local/lib/flimflam/test/backchannel',
chrome/test/functional/chromeos_gsm_compliance.py:                         
'/usr/local/lib/flimflam/test/fake-gsm-modem',
chrome/test/functional/chromeos_onc.py:    self.CleanupFlimflamDirsOnChromeOS()
chrome/browser/chromeos/cros/network_ip_config.h:// ipconfig types (see
flimflam/files/doc/ipconfig-api.txt)
chrome/browser/chromeos/cros/network_constants.h:// Connection enums (see
flimflam/include/service.h)
chrome/browser/chromeos/cros/network_constants.h:// Network enums (see
flimflam/include/network.h)
chrome/browser/chromeos/cros/network_constants.h:// Device enums (see
flimflam/include/device.h)
chrome/browser/chromeos/cros/network_constants.h:// connection errors (see
flimflam/include/service.h)
chrome/browser/resources/options/chromeos/internet_detail.js:      //
TODO(chocobo): Once ipconfig is moved to flimflam service objects,
chrome/browser/resources/chromeos/login/screen_error_message.js:            //
Otherwise (signal from flimflam / generate_204 got redirected)

[Greg Spencer (Chromium), 2012-09-06 16:23:32]

On 2012/09/06 11:28:35, Mattias Nissler wrote:
> $ grep -ri flimflam chrome | grep -v flimflam::

Hmm, I guess I didn't grep for .py or .js files.  The one .h was referring to an
actual flimflam header that doesn't exist in shill, so I left it.  I'll make a
pass on the .py files.

[Greg Spencer (Chromium), 2012-09-06 16:40:26]

On 2012/09/06 16:23:32, Greg Spencer (Chromium) wrote:
> On 2012/09/06 11:28:35, Mattias Nissler wrote:
> > $ grep -ri flimflam chrome | grep -v flimflam::
> 
> Hmm, I guess I didn't grep for .py or .js files.  The one .h was referring to
an
> actual flimflam header that doesn't exist in shill, so I left it.  I'll make a
> pass on the .py files.

OK, I took a look at all of these, and the python tests appear to be operating
on the actual flimflam service, and not shill, so I'm going to just leave them
as is.

I fixed the .js file comment.

[commit-bot: I haz the power, 2012-09-06 17:05:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gspencer@chromium.org/10915106/10001

[commit-bot: I haz the power, 2012-09-06 19:48:20]

Try job failure for 10915106-10001 (retry) on win_rel for step "runhooks".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-09-06 20:01:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gspencer@chromium.org/10915106/4002

[commit-bot: I haz the power, 2012-09-06 22:36:50]

Try job failure for 10915106-4002 (retry) on linux_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-09-07 18:36:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gspencer@chromium.org/10915106/4108

[commit-bot: I haz the power, 2012-09-07 20:53:59]

Change committed as 155477