Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 10915092: Update thumbnail_database to store times using ToInternalValue() (Closed)

Created:
8 years, 3 months ago by pkotwicz
Modified:
8 years, 3 months ago
Reviewers:
mazda, sky
CC:
chromium-reviews, browser-components-watch_chromium.org
Visibility:
Public.

Description

Update thumbnail_database to store times using ToInternalValue(). Modify ThumbnailScore::Equals() to test whether the time_at_snapshot match exactly. BUG=None Test=ThumbnailDatabaseTest.* ThumbnailScoreTest.* pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155037

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M chrome/browser/history/thumbnail_database.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/history/thumbnail_database_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/common/thumbnail_score.cc View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pkotwicz
Updated thumbnail_database to store last updated times for favicons and thumbnails in microsends using ToInternalValue(). ...
8 years, 3 months ago (2012-09-05 16:22:11 UTC) #1
sky
The code in thumbnaildb for topsites isn't really used anymore. It's in topsitesdb now and ...
8 years, 3 months ago (2012-09-05 16:57:17 UTC) #2
sky
LGTM
8 years, 3 months ago (2012-09-05 16:57:20 UTC) #3
mazda
lgtm I don't think thumbnail score with a low res time is used in any ...
8 years, 3 months ago (2012-09-05 17:03:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10915092/2001
8 years, 3 months ago (2012-09-05 20:45:18 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-05 22:33:19 UTC) #6
Change committed as 155037

Powered by Google App Engine
This is Rietveld 408576698