Combine audio decoding and video decoding onto a single thread.

Combine audio decoding and video decoding onto a single thread.

Our use of multithreaded video decoding results in a video decoding thread that is idle most of the time. Instead of being idle it can be doing real work like decoding audio. The end result is one less thread created per media element.

BUG=61293
TBR=brettw

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155179

[scherkus (not reviewing), 2012-09-05 16:06:08]

as discussed

[Ami GONE FROM CHROMIUM, 2012-09-06 08:39:40]

LGTM

CL description: y u no mention that this reduces thread usage by an entire
thread per media element??

https://chromiumcodereview.appspot.com/10915091/diff/12002/media/base/message...
File media/base/message_loop_factory.cc (right):

https://chromiumcodereview.appspot.com/10915091/diff/12002/media/base/message...
media/base/message_loop_factory.cc:38: name = "DecoderThread";
optional: s/Decoder/MediaDecoder/ ?
(no need for "media" in the Type enum b/c it's already scoped inside the media::
namespace)

[scherkus (not reviewing), 2012-09-06 09:02:33]

On 2012/09/06 08:39:40, Ami Fischman wrote:
> LGTM
> 
> CL description: y u no mention that this reduces thread usage by an entire
> thread per media element??

I am a humble man.

>
https://chromiumcodereview.appspot.com/10915091/diff/12002/media/base/message...
> File media/base/message_loop_factory.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10915091/diff/12002/media/base/message...
> media/base/message_loop_factory.cc:38: name = "DecoderThread";
> optional: s/Decoder/MediaDecoder/ ?
> (no need for "media" in the Type enum b/c it's already scoped inside the
media::
> namespace)

[scherkus (not reviewing), 2012-09-06 09:02:41]

https://chromiumcodereview.appspot.com/10915091/diff/12002/media/base/message...
File media/base/message_loop_factory.cc (right):

https://chromiumcodereview.appspot.com/10915091/diff/12002/media/base/message...
media/base/message_loop_factory.cc:38: name = "DecoderThread";
On 2012/09/06 08:39:40, Ami Fischman wrote:
> optional: s/Decoder/MediaDecoder/ ?
> (no need for "media" in the Type enum b/c it's already scoped inside the
media::
> namespace)

Done + for pipeline as well

[scherkus (not reviewing), 2012-09-06 09:08:41]

TBR=brettw for content/renderer/ and webkit/support/ OWNERS

[commit-bot: I haz the power, 2012-09-06 09:11:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/10915091/9002

[commit-bot: I haz the power, 2012-09-06 13:13:44]

Change committed as 155179