Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Unified Diff: lib/compiler/implementation/scanner/keyword.dart

Issue 10915083: Change assert implementation to not depend on a top-level function called 'assert'. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/scanner/keyword.dart
diff --git a/lib/compiler/implementation/scanner/keyword.dart b/lib/compiler/implementation/scanner/keyword.dart
index 87aeaf6fd520e97dde87a0cd95fe2be4a793b833..c071910865379c38b8ed67d1f90a6b02937e6cca 100644
--- a/lib/compiler/implementation/scanner/keyword.dart
+++ b/lib/compiler/implementation/scanner/keyword.dart
@@ -36,24 +36,27 @@ class Keyword implements SourceString {
static const Keyword VOID = const Keyword("void");
static const Keyword WHILE = const Keyword("while");
- // Pseudo keywords:
+ // Built-in identifiers.
ahe 2012/09/05 11:09:54 Why is it necessary to change this file?
Lasse Reichstein Nielsen 2012/09/05 12:51:20 It isn't. I keep getting confused by this "pseudo
static const Keyword ABSTRACT = const Keyword("abstract", isPseudo: true);
static const Keyword AS = const Keyword("as", info: AS_INFO, isPseudo: true);
static const Keyword ASSERT = const Keyword("assert", isPseudo: true);
+ // And "Dynamic".
Johnni Winther 2012/09/05 09:07:05 Is there no const for Dynamic? Don't we need it?
ngeoffray 2012/09/05 10:37:10 What is this comment for?
Lasse Reichstein Nielsen 2012/09/05 12:51:20 Apparently not, to both questions. This was just a
Lasse Reichstein Nielsen 2012/09/05 12:51:20 Reminder that "Dynamic" is a built-in identifier,
static const Keyword EXTERNAL = const Keyword("external", isPseudo: true);
static const Keyword FACTORY = const Keyword("factory", isPseudo: true);
static const Keyword GET = const Keyword("get", isPseudo: true);
static const Keyword IMPLEMENTS = const Keyword("implements", isPseudo: true);
+ static const Keyword OPERATOR = const Keyword("operator", isPseudo: true);
+ static const Keyword SET = const Keyword("set", isPseudo: true);
+ static const Keyword STATIC = const Keyword("static", isPseudo: true);
+ static const Keyword TYPEDEF = const Keyword("typedef", isPseudo: true);
+
+ // Pseudo keywords:
static const Keyword IMPORT = const Keyword("import", isPseudo: true);
static const Keyword INTERFACE = const Keyword("interface", isPseudo: true);
static const Keyword LIBRARY = const Keyword("library", isPseudo: true);
static const Keyword NATIVE = const Keyword("native", isPseudo: true);
- static const Keyword OPERATOR = const Keyword("operator", isPseudo: true);
static const Keyword ON = const Keyword("on", isPseudo: true);
- static const Keyword SET = const Keyword("set", isPseudo: true);
static const Keyword SOURCE = const Keyword("source", isPseudo: true);
- static const Keyword STATIC = const Keyword("static", isPseudo: true);
- static const Keyword TYPEDEF = const Keyword("typedef", isPseudo: true);
static const List<Keyword> values = const <Keyword> [
AS,

Powered by Google App Engine
This is Rietveld 408576698