Change assert implementation to not depend on a top-level function called 'assert'.

lib/compiler/implementation/universe.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Universe {
   Map<Element, CodeBuffer> generatedCode;
   Map<Element, CodeBuffer> generatedBailoutCode;
   final Set<ClassElement> instantiatedClasses;
   final Set<FunctionElement> staticFunctionsNeedingGetter;
   final Map<SourceString, Set<Selector>> invokedNames;
@@ skipping 145 matching lines @@
   bool isSetter() => kind === SelectorKind.SETTER;
   bool isCall() => kind === SelectorKind.CALL;
 
   bool isIndex() => kind === SelectorKind.INDEX && argumentCount == 1;
   bool isIndexSet() => kind === SelectorKind.INDEX && argumentCount == 2;
 
   bool isOperator() => kind === SelectorKind.OPERATOR;
   bool isUnaryOperator() => isOperator() && argumentCount == 0;
   bool isBinaryOperator() => isOperator() && argumentCount == 1;
 
+  /** Check whether this is a call to 'assert' with one positional parameter. */
+  bool isAssertSyntax() {
+    return (isCall() &&
+            name == const SourceString("assert") &&

[ahe, 2012/09/06 22:25:53]

name.stringValue === 'assert'

[Lasse Reichstein Nielsen, 2012/09/07 10:18:57]

Done.

+            argumentCount == 1 &&
+            namedArgumentCount == 0);
+  }
+
   int hashCode() => argumentCount + 1000 * namedArguments.length;
   int get namedArgumentCount => namedArguments.length;
   int get positionalArgumentCount => argumentCount - namedArgumentCount;
   DartType get receiverType => null;
 
   bool applies(Element element, Compiler compiler)
       => appliesUntyped(element, compiler);
 
   bool appliesUntyped(Element element, Compiler compiler) {
     if (element.isSetter()) return isSetter();
@@ skipping 114 matching lines @@
 
   static bool sameNames(List<SourceString> first, List<SourceString> second) {
     for (int i = 0; i < first.length; i++) {
       if (first[i] != second[i]) return false;
     }
     return true;
   }
 
   bool operator ==(other) {
     if (other is !Selector) return false;
-    return receiverType === other.receiverType
-        && equalsUntyped(other);
+    Selector otherSelector = other;

[ahe, 2012/09/06 22:25:53]

This change is unnecessary and doesn't improve readability of the code.

[Lasse Reichstein Nielsen, 2012/09/07 10:18:57]

Done.

+    return receiverType === otherSelector.receiverType
+        && equalsUntyped(otherSelector);
   }
 
   bool equalsUntyped(Selector other) {
     return name == other.name
            && library === other.library
            && argumentCount == other.argumentCount
            && namedArguments.length == other.namedArguments.length
            && sameNames(namedArguments, other.namedArguments);
   }
 
@@ skipping 86 matching lines @@
 
     if (!self.isInterface() && self.isSubclassOf(other)) {
       // Resolve an invocation of [element.name] on [self]. If it
       // is found, this selector is a candidate.
       return hasElementIn(self, element) && appliesUntyped(element, compiler);
     }
 
     return false;
   }
 }