Change assert implementation to not depend on a top-level function called 'assert'.

lib/compiler/implementation/resolver.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface TreeElements {
   Element operator[](Node node);
   Selector getSelector(Send send);
   DartType getType(TypeAnnotation annotation);
   bool isParameterChecked(Element element);
 }
@@ skipping 1119 matching lines @@
     visitIn(node.statements, new BlockScope(scope));
   }
 
   visitDoWhile(DoWhile node) {
     visitLoopBodyIn(node, node.body, new BlockScope(scope));
     visit(node.condition);
   }
 
   visitEmptyStatement(EmptyStatement node) { }
 
+  bool isAssertSyntax(Expression expression) {

[ngeoffray, 2012/09/05 10:37:10]

I'm not sure about this code. I wish we could avoid decomposing an Expression
like this. As discussed, we should probably revisit the spec for assert.

[Lasse Reichstein Nielsen, 2012/09/05 12:51:20]

I've moved this into visitSend now, so it only deconstructs one level (well, two
for the identifier).

+    Send send = expression.asSend();
+    if (send === null) return false;
+    if (send.receiver !== null) return false;
+    if (!send.isCall) return false;
+    Identifier selector = send.selector.asIdentifier();
+    if (selector === null) return false;
+    if (selector.source.stringValue !== "assert") return false;
+    if (send.argumentCount() != 1) return false;
+    return true;
+  }
+
   visitExpressionStatement(ExpressionStatement node) {
+    if (isAssertSyntax(node.expression)) {

[ahe, 2012/09/05 11:09:54]

I'm going to express myself unambiguously. I do not mean to offend anyone :-)

But... this is simply wrong.

The resolver works bottom up, and this mode of operation is crucial for
performance and sanity.

If it isn't clear what I mean by bottom-up, please do not hesitate to discuss it
in person.

[Lasse Reichstein Nielsen, 2012/09/05 12:51:20]

Try seeing if the new version is better.

+      Send send = node.expression;
+      Element scopedAssert = scope.lexicalLookup(const SourceString("assert"));
+      if (scopedAssert == null) {
+        // Compile as a call to a top-level function.
+        Element target = compiler.assertMethod;
+        Selector selector = resolveSelector(send);
+        resolveArguments(send.argumentsNode);
+        useElement(send, target);
+        registerSend(selector, target);
+        return;
+      }
+    }
     visit(node.expression);
   }
 
   visitFor(For node) {
     Scope blockScope = new BlockScope(scope);
     visitIn(node.initializer, blockScope);
     visitIn(node.condition, blockScope);
     visitIn(node.update, blockScope);
     visitLoopBodyIn(node, node.body, blockScope);
   }
@@ skipping 221 matching lines @@
     // we need to register that fact that we may be calling a closure
     // with the same arguments.
     if (node.isCall &&
         (Element.isInvalid(target) ||
          target.isGetter() ||
          Elements.isClosureSend(node, target))) {
       Selector call = new Selector.callClosureFrom(selector);
       world.registerDynamicInvocation(call.name, call);
     }
 
-    // TODO(ngeoffray): We should do the check in
-    // visitExpressionStatement instead.
-    if (target === compiler.assertMethod && !node.isCall) {
-      // We can only use assert by calling it.
-      if (!inInstanceContext) {
-        error(node, MessageKind.MISSING_ARGUMENTS_TO_ASSERT, [node]);
-      }
-      target = null;
-    }
-
     // TODO(ngeoffray): Warn if target is null and the send is
     // unqualified.
     useElement(node, target);
     registerSend(selector, target);
     return node.isPropertyAccess ? target : null;
   }
 
   visitSendSet(SendSet node) {
     Element target = resolveSend(node);
     Element setter = target;
@@ skipping 1148 matching lines @@
     return e;
   }
 }
 
 class Scope {
   final Element element;
   final Scope parent;
 
   Scope(this.parent, this.element);
   abstract Element add(Element element);
-  abstract Element lookup(SourceString name);
+
+  Element lookup(SourceString name) {
+    Element result = localLookup(name);
+    if (result != null) return result;
+    return parent.lookup(name);
+  }
+
+  Element lexicalLookup(SourceString name) {
+    Element result = localLookup(name);
+    if (result != null) return result;
+    return parent.lexicalLookup(name);
+  }
+
+  abstract Element localLookup(SourceString name);
 }
 
 /**
  * [TypeDeclarationScope] defines the outer scope of a type declaration in
  * which the declared type variables and the entities in the enclosing scope are
  * available but where declared and inherited members are not available. This
  * scope is only used for class/interface declarations during resolution of the
  * class hierarchy. In all other cases [ClassScope] is used.
  */
 class TypeDeclarationScope extends Scope {
   TypeDeclarationElement get element => super.element;
 
   TypeDeclarationScope(parent, TypeDeclarationElement element)
       : super(parent, element) {
     assert(parent !== null);
   }
 
   Element add(Element newElement) {
     throw "Cannot add element to TypeDeclarationScope";
   }
 
   /**
    * Looks up [name] within the type variables declared in [element].
    */
   Element lookupTypeVariable(SourceString name) {
     return null;
   }
 
-  Element lookup(SourceString name) {
+  Element localLookup(SourceString name) {
     Link<DartType> typeVariableLink = element.typeVariables;
     while (!typeVariableLink.isEmpty()) {
       TypeVariableType typeVariable = typeVariableLink.head;
       if (typeVariable.name == name) {
         return typeVariable.element;
       }
       typeVariableLink = typeVariableLink.tail;
     }
-
-    return parent.lookup(name);
+    return null;
   }
 
   String toString() =>
       '$element${element.typeVariables} > $parent';
 }
 
 class MethodScope extends Scope {
   final Map<SourceString, Element> elements;
 
   MethodScope(Scope parent, Element element)
       : super(parent, element),
         this.elements = new Map<SourceString, Element>() {
     assert(parent !== null);
   }
 
-  Element lookup(SourceString name) {
-    Element found = elements[name];
-    if (found !== null) return found;
-    return parent.lookup(name);
-  }
+  Element localLookup(SourceString name) => elements[name];
 
   Element add(Element newElement) {
     if (elements.containsKey(newElement.name)) {
       return elements[newElement.name];
     }
     elements[newElement.name] = newElement;
     return newElement;
   }
 
   String toString() => '$element${elements.getKeys()} > $parent';
 }
 
 class BlockScope extends MethodScope {
   BlockScope(Scope parent) : super(parent, parent.element);
 
   String toString() => 'block${elements.getKeys()} > $parent';
 }
 
 /**
  * [ClassScope] defines the inner scope of a class/interface declaration in
  * which declared members, declared type variables, entities in the enclosing
  * scope and inherited members are available, in the given order.
  */
 class ClassScope extends TypeDeclarationScope {
   ClassScope(Scope parentScope, ClassElement element)
       : super(parentScope, element);
 
-  Element lookup(SourceString name) {
+  Element localLookup(SourceString name) {
     ClassElement cls = element;
     Element result = cls.lookupLocalMember(name);
     if (result !== null) return result;
-    result = super.lookup(name);
-    if (result != null) return result;
+    return super.localLookup(name);
+  }
+
+  Element lookup(SourceString name) {
+    Element result = localLookup(name);
+    if (result !== null) return result;
+    result = parent.lexicalLookup(name);
+    if (result !== null) return result;
+    ClassElement cls = element;
     return cls.lookupSuperMember(name);
   }
 
   Element add(Element newElement) {
     throw "Cannot add an element in a class scope";
   }
 
   String toString() => '$element > $parent';
 }
 
 class TopScope extends Scope {
   LibraryElement get library => element;
 
   TopScope(LibraryElement library) : super(null, library);
-  Element lookup(SourceString name) {
-    return library.find(name);
-  }
+
+  Element localLookup(SourceString name) => library.find(name);
+  Element lookup(SourceString name) => localLookup(name);
+  Element lexicalLookup(SourceString name) => localLookup(name);
 
   Element add(Element newElement) {
     throw "Cannot add an element in the top scope";
   }
   String toString() => '$element';
 }