Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 10915079: remove --enable-experimental-extension-apis from packaged app shortcut args (Closed)

Created:
8 years, 3 months ago by tapted
Modified:
8 years, 3 months ago
Reviewers:
benwells, sky
CC:
koz (OOO until 15th September)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Packaged apps are now enabled by default (and arguments on launcher shortcuts are unlikely to function when chrome is already running), so this extra argument on shortcuts can be dropped. BUG=146037 TEST=ensure shortcuts for packaged apps are still created (e.g. on desktop), and can execute successfully Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155118

Patch Set 1 #

Total comments: 1

Patch Set 2 : is_platform_app data member on ShortcutInfo no longer required #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -21 lines) Patch
M chrome/browser/extensions/app_shortcut_manager.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/shell_integration.h View 1 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/shell_integration.cc View 1 3 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/shell_integration_linux.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/shell_integration_linux.cc View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/shell_integration_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_win.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tapted
can't do a try-build for Windows yet.. so that change is as-yet uncompiled, but ./unit_tests ...
8 years, 3 months ago (2012-09-05 03:52:38 UTC) #1
benwells
https://chromiumcodereview.appspot.com/10915079/diff/1/chrome/browser/shell_integration.h File chrome/browser/shell_integration.h (left): https://chromiumcodereview.appspot.com/10915079/diff/1/chrome/browser/shell_integration.h#oldcode94 chrome/browser/shell_integration.h:94: bool is_platform_app; Can we delete this field from ShortcutInfo ...
8 years, 3 months ago (2012-09-05 03:57:50 UTC) #2
tapted
revised patch set, with unused is_platform_app data member removed from ShellIntegration::ShortcutInfo (needs build test against ...
8 years, 3 months ago (2012-09-05 04:59:11 UTC) #3
benwells
lgtm I've put it in for some try runs on various bots. If all looks ...
8 years, 3 months ago (2012-09-05 05:06:40 UTC) #4
tapted
Hi Scott, are you able to review my (first) chrome CL? It's centered around a ...
8 years, 3 months ago (2012-09-05 09:54:53 UTC) #5
sky
LGTM
8 years, 3 months ago (2012-09-05 14:03:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/10915079/2002
8 years, 3 months ago (2012-09-05 23:53:33 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-06 04:19:26 UTC) #8
Change committed as 155118

Powered by Google App Engine
This is Rietveld 408576698