Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 10915074: Fix up cc stubs and bindings to work in windows (Closed)

Created:
8 years, 3 months ago by jamesr
Modified:
8 years, 3 months ago
Reviewers:
nduca
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Fix up cc stubs and bindings to work in windows Windows is stricter than other platforms in a few ways: *) All files referenced in a .gyp have to actually exist or the generator complains *) Symbols have to be defined in only one object file *) NO_ERROR is #defined by some win32 headers and collides with GL headers *) WEBKIT_DLL has to be set for targets that define exported symbols This fixes these in the cc stubs. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154899

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -17 lines) Patch
M cc/cc.gyp View 1 chunk +9 lines, -5 lines 0 comments Download
M cc/stubs/GraphicsContext3D.h View 1 chunk +5 lines, -6 lines 0 comments Download
M cc/stubs/TextStream.h View 1 chunk +5 lines, -4 lines 0 comments Download
M webkit/compositor_bindings/compositor_bindings.gyp View 1 chunk +8 lines, -2 lines 0 comments Download
M webkit/compositor_bindings/stubs/public/WebTransformationMatrix.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jamesr
8 years, 3 months ago (2012-09-05 00:31:32 UTC) #1
nduca
8 years, 3 months ago (2012-09-05 01:23:16 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698