Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 10915072: add --force option for presubmit command (Closed)

Created:
8 years, 3 months ago by Sam Clegg
Modified:
8 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Base URL:
https://git.chromium.org/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Add --force option for presubmit command which allows one to run the presubmit script without submitting locally (alternative would be to make this a warning I guess). Also, pass option.verbose through to DoGetTrySlaves() so it will log which PRESUBMIT files are taking part in the decision. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154838

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M git_cl.py View 1 chunk +5 lines, -2 lines 0 comments Download
M trychange.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Sam Clegg
8 years, 3 months ago (2012-09-04 22:37:09 UTC) #1
M-A Ruel
lgtm
8 years, 3 months ago (2012-09-04 22:51:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/10915072/1
8 years, 3 months ago (2012-09-04 23:04:59 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-04 23:07:43 UTC) #4
Change committed as 154838

Powered by Google App Engine
This is Rietveld 408576698