Add Copy URL option to Omnibox context menu when URL is replaced by Instant Extended.

chrome/browser/ui/views/omnibox/omnibox_view_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/omnibox/omnibox_view_win.h"
 
 #include <algorithm>
 #include <locale>
 #include <string>
 
@@ skipping 997 matching lines @@
         if (model()->CanPasteAndGo(collapsed_text))
           model()->PasteAndGo(collapsed_text);
       }
       return CopyOrLinkDragOperation(event.source_operations());
     }
   }
 
   return ui::DragDropTypes::DRAG_NONE;
 }
 
+bool OmniboxViewWin::ShouldAddCopyURL() const {

[Peter Kasting, 2012/09/05 22:32:58]

Nit: I'm fine with inlining this into IsCommandIdEnabled() and making each
switch case there be linebroken in a more typical manner.

[dominich, 2012/09/05 23:35:34]

Done.

+  return !!CanCopy() &&
+      !model()->user_input_in_progress() &&
+      toolbar_model()->WouldReplaceSearchURLWithSearchTerms();
+}
+
+void OmniboxViewWin::CopyURL() {
+  const string16& text = toolbar_model()->GetText(false);
+  const GURL& url = toolbar_model()->GetURL();
+
+  ui::ScopedClipboardWriter scw(g_browser_process->clipboard(),
+                                ui::Clipboard::BUFFER_STANDARD);
+  scw.WriteText(text);
+  scw.WriteBookmark(text, url.spec());
+  scw.WriteHyperlink(net::EscapeForHTML(text), url.spec());

[Peter Kasting, 2012/09/05 22:32:58]

Don't call WriteHyperlink (see https://chromiumcodereview.appspot.com/10827330
).

To ensure these stay in sync, you might want to factor the end of OnCopy() out
to its own function, and call it from both there and here.  (Something like
"DoCopy(text, url, write_url);" and have that function create the
ScopedClipboardWriter.  Then this function would become a single statement.)

[dominich, 2012/09/05 23:35:34]

Done.

+}
+
 bool OmniboxViewWin::SkipDefaultKeyEventProcessing(const ui::KeyEvent& event) {
   ui::KeyboardCode key = event.key_code();
   // We don't process ALT + numpad digit as accelerators, they are used for
   // entering special characters.  We do translate alt-home.
   if (event.IsAltDown() && (key != ui::VKEY_HOME) &&
       views::NativeTextfieldWin::IsNumPadDigit(key,
           (event.flags() & ui::EF_EXTENDED) != 0))
     return true;
 
   // Skip accelerators for key combinations omnibox wants to crack. This list
@@ skipping 49 matching lines @@
 
 bool OmniboxViewWin::IsCommandIdChecked(int command_id) const {
   return false;
 }
 
 bool OmniboxViewWin::IsCommandIdEnabled(int command_id) const {
   switch (command_id) {
     case IDS_UNDO:         return !!CanUndo();
     case IDC_CUT:          return !!CanCut();
     case IDC_COPY:         return !!CanCopy();
+    case IDC_COPY_URL:     return ShouldAddCopyURL();
     case IDC_PASTE:        return !!CanPaste();
     case IDS_PASTE_AND_GO: return model()->CanPasteAndGo(GetClipboardText());
     case IDS_SELECT_ALL:   return !!CanSelectAll();
     case IDS_EDIT_SEARCH_ENGINES:
       return command_updater()->IsCommandEnabled(IDC_EDIT_SEARCH_ENGINES);
     default:
       NOTREACHED();
       return false;
   }
 }
@@ skipping 33 matching lines @@
       break;
 
     case IDC_CUT:
       Cut();
       break;
 
     case IDC_COPY:
       Copy();
       break;
 
+    case IDC_COPY_URL:
+      CopyURL();
+      break;
+
     case IDC_PASTE:
       Paste();
       break;
 
     case IDS_SELECT_ALL:
       SelectAll(false);
       break;
 
     case IDS_EDIT_SEARCH_ENGINES:
       command_updater()->ExecuteCommand(IDC_EDIT_SEARCH_ENGINES);
@@ skipping 1491 matching lines @@
   return (rect.left - client_rect.left) + (client_rect.right - rect.right);
 }
 
 int OmniboxViewWin::WidthNeededToDisplay(const string16& text) const {
   // Use font_.GetStringWidth() instead of
   // PosFromChar(location_entry_->GetTextLength()) because PosFromChar() is
   // apparently buggy. In both LTR UI and RTL UI with left-to-right layout,
   // PosFromChar(i) might return 0 when i is greater than 1.
   return font_.GetStringWidth(text) + GetHorizontalMargin();
 }