Moving extension_processes_api to api/processes

Moving extension_processes_api to api/processes

Also putting it into extensions namespace and removing
redundant "extension" prefixes from names.


BUG=101244
TEST=N/A, no code change, moving stuff around only


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155151

[vabr (Chromium), 2012-09-04 18:47:41]

Hi Mike,

As a chrome/browser/extensions/OWNER, could you please review this
moving+renaming CL?

Thanks,
Vaclav

[miket_OOO, 2012-09-04 19:20:07]

LGTM and thanks!

http://codereview.chromium.org/10915067/diff/1/chrome/chrome_browser_extensio...
File chrome/chrome_browser_extensions.gypi (right):

http://codereview.chromium.org/10915067/diff/1/chrome/chrome_browser_extensio...
chrome/chrome_browser_extensions.gypi:41: '../third_party/re2/re2.gyp:re2',
Thanks!

[commit-bot: I haz the power, 2012-09-05 07:53:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vabr@chromium.org/10915067/1

[commit-bot: I haz the power, 2012-09-05 07:53:21]

Failed to apply patch for chrome/browser/extensions/event_router.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/extensions/event_router.cc
Hunk #1 succeeded at 9 with fuzz 1.
Hunk #2 FAILED at 155.
Hunk #3 succeeded at 179 (offset 5 lines).
1 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/extensions/event_router.cc.rej

[vabr (Chromium), 2012-09-05 08:21:28]

Thanks Mike!

I had to rebase, and now I'm sending it to CQ.
Also adding brettw@ to TBR for OWNERS rubber-stamp of the *.gypi changes (just
TBR because they are straightforward).

Vaclav

[commit-bot: I haz the power, 2012-09-05 08:21:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vabr@chromium.org/10915067/8001

[commit-bot: I haz the power, 2012-09-05 09:14:58]

Try job failure for 10915067-8001 (retry) on android for steps "compile, build"
(clobber build).
It's a second try, previously, steps "compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

[vabr (Chromium), 2012-09-05 09:42:14]

On 2012/09/05 09:14:58, I haz the power (commit-bot) wrote:
> Try job failure for 10915067-8001 (retry) on android for steps "compile,
build"
> (clobber build).
> It's a second try, previously, steps "compile, build" failed.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

Hmm, the android failure looks strange.
Trying to figure out whether I missed a place in the android-specific sections
in some *.gypi .

[vabr (Chromium), 2012-09-05 10:21:42]

Brett,

Moving you from TBR to before-commit reviewers, because I would appreciate if
you can take a look at my change to *.gypi, in particular to
chrome/chrome_browser_extensions.gypi .

I had to do the following:
Add processes_api_constants.cc to the explicit includes on line 650 in
chrome_browser_extensions.gypi .
Unlike processes_api.cc, *constants.cc was not there before the renaming,
because it was matched by neither of the exclude patterns on lines 625 and 626
(^browser/extensions/api/, ^browser/extensions/.*_api\.cc$). However, after
being moved into /api, it started to match the first exclude (whereas
processes_api.cc only switched from matching the 1st instead of the 2nd).

So adding processes_api_constants.cc as explicit include should actually be
leaving things as they were before.

Cheers,
Vaclav

[brettw, 2012-09-05 22:16:17]

To be honest, I don't really know about the gypi thing. What you did seems "not
wrong" when looking at the surrounding files. So LGTM :)

[commit-bot: I haz the power, 2012-09-06 06:40:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vabr@chromium.org/10915067/11003

[commit-bot: I haz the power, 2012-09-06 09:03:32]

Change committed as 155151