Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 10915061: Add MainHook to media unittests. (Closed)

Created:
8 years, 3 months ago by Milan Broum
Modified:
8 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add MainHook to media unittests. MainHooks are in particular used on iOS to prevent the system from killing the test application at startup. See https://chromiumcodereview.appspot.com/10690161/ for more context. BUG=b/6754065 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154946

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unrelated empty line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M media/base/run_all_unittests.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Milan Broum
The first bit of iOS media upstreaming effort. Stuart for the initial look and Nilesh ...
8 years, 3 months ago (2012-09-04 14:10:36 UTC) #1
stuartmorgan
LGTM with nit https://chromiumcodereview.appspot.com/10915061/diff/1/media/base/run_all_unittests.cc File media/base/run_all_unittests.cc (right): https://chromiumcodereview.appspot.com/10915061/diff/1/media/base/run_all_unittests.cc#newcode20 media/base/run_all_unittests.cc:20: No need to add this blank ...
8 years, 3 months ago (2012-09-04 14:24:30 UTC) #2
Milan Broum
https://chromiumcodereview.appspot.com/10915061/diff/1/media/base/run_all_unittests.cc File media/base/run_all_unittests.cc (right): https://chromiumcodereview.appspot.com/10915061/diff/1/media/base/run_all_unittests.cc#newcode20 media/base/run_all_unittests.cc:20: On 2012/09/04 14:24:30, stuartmorgan wrote: > No need to ...
8 years, 3 months ago (2012-09-04 14:38:21 UTC) #3
nilesh
Adding media/OWNERS
8 years, 3 months ago (2012-09-04 16:04:48 UTC) #4
Ami GONE FROM CHROMIUM
lgtm
8 years, 3 months ago (2012-09-05 08:26:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/milanb@chromium.org/10915061/3002
8 years, 3 months ago (2012-09-05 09:23:37 UTC) #6
commit-bot: I haz the power
8 years, 3 months ago (2012-09-05 13:26:49 UTC) #7
Change committed as 154946

Powered by Google App Engine
This is Rietveld 408576698