Issue 10915059: Change test so that it checks whether the exception thrown is ObjectNotClosureException or NoSuchMe…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10915059: Change test so that it checks whether the exception thrown is ObjectNotClosureException or NoSuchMe… (Closed)

Created:
8 years, 3 months ago by ngeoffray

Modified:
8 years, 3 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, ahe

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Change test so that it checks whether the exception thrown is ObjectNotClosureException or NoSuchMethodException. Some browsers just generate a NoSuchMethodException. Committed: https://code.google.com/p/dart/source/detail?r=11806

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -533 lines)			Patch
M	tests/compiler/dart2js_extra/dart2js_extra.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
D	tests/compiler/dart2js_extra/naming_test.dart	View		1 chunk	+0 lines, -526 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		3 chunks	+0 lines, -3 lines	0 comments	Download
M	tests/language/naming_test.dart	View	1	1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

I also removed the duplicate naming_test, now that the commented line does not crash anymore.

8 years, 3 months ago (2012-09-04 12:03:56 UTC) #1

kasperl

LGTM. https://chromiumcodereview.appspot.com/10915059/diff/1/tests/language/naming_test.dart File tests/language/naming_test.dart (right): https://chromiumcodereview.appspot.com/10915059/diff/1/tests/language/naming_test.dart#newcode515 tests/language/naming_test.dart:515: (e) => e is ObjectNotClosureException || e is ...

8 years, 3 months ago (2012-09-04 12:06:18 UTC) #2

ngeoffray

8 years, 3 months ago (2012-09-04 12:16:20 UTC) #3

Thanks Kasper.

https://chromiumcodereview.appspot.com/10915059/diff/1/tests/language/naming_...
File tests/language/naming_test.dart (right):

https://chromiumcodereview.appspot.com/10915059/diff/1/tests/language/naming_...
tests/language/naming_test.dart:515: (e) => e is ObjectNotClosureException || e
is NoSuchMethodException);
On 2012/09/04 12:06:18, kasperl wrote:
> Maybe add a comment that explains why both of these exceptions are
"acceptable"?

Done.

Expand Messages | Collapse Messages