Implement argument definition test in the vm.

runtime/vm/scopes.cc

Index: runtime/vm/scopes.cc
===================================================================
--- runtime/vm/scopes.cc	(revision 11663)
+++ runtime/vm/scopes.cc	(working copy)
@@ -12,11 +12,6 @@
 
 namespace dart {
 
-const char* SourceLabel::kDefaultLabelName = ":L";
-
-const char* LocalVariable::kSavedContextVarName = ":saved_entry_context_var";
-
-
 int SourceLabel::FunctionLevel() const {
   ASSERT(owner() != NULL);
   return owner()->function_level();
@@ -233,7 +228,7 @@
       (!parent()->HasContextLevel()) ||
       (parent()->context_level() != context_level()))) {
     // This is the outermost scope with a context level or this scope's
-    // context level differes from its parent's level.
+    // context level differs from its parent's level.
     VarDesc desc;
     desc.name = &String::Handle();  // No name.
     desc.info.kind =  RawLocalVarDescriptors::kContextLevel;
@@ -263,7 +258,8 @@
         desc.info.end_pos = var->owner()->end_token_pos();
         desc.info.index = var->index();
         vars->Add(desc);
-      } else if (var->name().Equals(LocalVariable::kSavedContextVarName)) {
+      } else if (var->name().Equals(
+            Symbols::Name(Symbols::kSavedEntryContextVar))) {

[hausner, 2012/08/31 00:34:55]

Isn't it enough to just allocate a string handle for the symbol, which gets
allocated as a RawString.

...Equals(String::Handle(Symbols::SavedEntryContextVar()))

[regis, 2012/08/31 01:36:18]

Yes, but it seems like a waste to allocate all these handles in this recursive
function just to access a compile time char*. This is probably why you had the
static char* in the first place. I need also need a char* elsewhere for the
arg_desc variable name and I thought that making all these predefined symbols as
char* was convenient. But if it causes any issue, let's revisit.   

[hausner, 2012/08/31 05:56:26]

Ok, that's a valid reason that I buy. I hope Equals does not allocate a handle
(I don't have the source code handy).

On 2012/08/31 01:36:18, regis wrote:

         // This is the local variable in which the function saves the
         // caller's chain of closure contexts (caller's CTX register).
         VarDesc desc;
@@ -275,6 +271,7 @@
         desc.info.index = var->index();
         vars->Add(desc);
       }
+      // The saved arguments descriptor variable is not currently collected.
     }
   }
   LocalScope* child = this->child();