Issue 10915002: Convert the history pyauto tests to a browser_tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10915002: Convert the history pyauto tests to a browser_tests. (Closed)

Created:
8 years, 3 months ago by jam

Modified:
8 years, 3 months ago

Reviewers:
erikwright (departed), sky

CC:
chromium-reviews, Nirnimesh, browser-components-watch_chromium.org, anantha, dyu1, brettw-cc_chromium.org, dennis_jeffrey

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Convert the history pyauto tests to browser_tests. testStarredBookmarkInHistory was skipped since it wasn't very useful (it got the star state from the bookmark code, which it also called) testForge is testing adding and reading a url from the history database, which is a duplicate of many browser and unit tests (i.e. HistoryTest.*) testHttpsHistory is a duplicate of HistoryTest.MakeIntranetURLsTyped testFtpHistory is not very useful since if multiple schemes work, we don't need to test every scheme testAppendTabAddPage is a duplicate of a subset of testReloadBringPageToTop testOpenWindowAddPage is a duplicate of a subset of testMultiTabsWindowsHistory I fixed a bug in ui_test_utils::NavigateToURLWithDisposition which made it not wait on NEW_BACKGROUND_TAB disposition. I also made HistoryEnumerator return the urls in sorted order. BUG=143637 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154229

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+292 lines, -422 lines)			Patch
M	chrome/browser/download/download_browsertest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/DEPS	View	1 2	1 chunk	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/history/history_browsertest.cc	View		4 chunks	+226 lines, -7 lines	0 comments	Download
M	chrome/browser/policy/policy_browsertest.cc	View		3 chunks	+2 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/find_bar/find_bar_host_browsertest.cc	View		5 chunks	+1 line, -18 lines	0 comments	Download
M	chrome/test/base/ui_test_utils.h	View		2 chunks	+15 lines, -8 lines	0 comments	Download
M	chrome/test/base/ui_test_utils.cc	View		6 chunks	+43 lines, -17 lines	0 comments	Download
M	chrome/test/functional/PYAUTO_TESTS	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/test/functional/history.py	View		1 chunk	+0 lines, -358 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 10915002: Convert the history pyauto tests to a browser_tests. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : make DEPS clearer/cleaner after discussion with erikwright #

Messages