Switch LoadTimeStatsTabHelper to use WebContentsUserData.

chrome/browser/net/load_time_stats.cc

Index: chrome/browser/net/load_time_stats.cc
diff --git a/chrome/browser/net/load_time_stats.cc b/chrome/browser/net/load_time_stats.cc
index 4697dbfa18972129dfef7afcc915df28fa78f20b..c1b2491b07273de49c2571f0b3fbecb77f20a564 100644
--- a/chrome/browser/net/load_time_stats.cc
+++ b/chrome/browser/net/load_time_stats.cc
@@ -11,7 +11,6 @@
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/io_thread.h"
 #include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/ui/tab_contents/tab_contents.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
@@ -255,9 +254,12 @@ class LoadTimeStats::URLRequestStats {
   base::TimeDelta status_times_[REQUEST_STATUS_MAX];
 };
 
-LoadTimeStatsTabHelper::LoadTimeStatsTabHelper(TabContents* tab)
-    : content::WebContentsObserver(tab->web_contents()) {
-  is_otr_profile_ = tab->profile()->IsOffTheRecord();
+int LoadTimeStatsTabHelper::kUserDataKey;

[cbentzel, 2012/09/18 13:55:41]

Nit: // static comment? 

Also - would it make sense to explain that the value doesn't matter, or is this
such an idiom for WebContentsUserData that it isn't needed at each key site.

[Avi (use Gerrit), 2012/09/18 14:11:47]

This is an idiom; every WebContentsUserData gets one :/

+
+LoadTimeStatsTabHelper::LoadTimeStatsTabHelper(
+    content::WebContents* web_contents)
+    : content::WebContentsObserver(web_contents) {
+  is_otr_profile_ = web_contents->GetBrowserContext()->IsOffTheRecord();
 }
 
 LoadTimeStatsTabHelper::~LoadTimeStatsTabHelper() {