Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 10914319: UserScriptListener: Don't resume requests that it didn't defer. (Closed)

Created:
8 years, 3 months ago by mmenke
Modified:
8 years, 3 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

UserScriptListener: Don't resume requests that it didn't defer. While this behavior doesn't currently break anything, it makes issue 130854 occur more often, and seems rather fragile. A fix for 130854 is in a separate CL. R=mpcomplete@chromium.org BUG=130854 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157211

Patch Set 1 #

Patch Set 2 : Switch to more consistent ordering #

Total comments: 2

Patch Set 3 : Fix bad comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2 lines) Patch
M chrome/browser/extensions/user_script_listener.cc View 1 1 chunk +17 lines, -2 lines 0 comments Download
M chrome/browser/extensions/user_script_listener_unittest.cc View 1 2 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mmenke
8 years, 3 months ago (2012-09-17 18:30:01 UTC) #1
Matt Perry
LGTM, thanks for fixing this. http://codereview.chromium.org/10914319/diff/8001/chrome/browser/extensions/user_script_listener_unittest.cc File chrome/browser/extensions/user_script_listener_unittest.cc (right): http://codereview.chromium.org/10914319/diff/8001/chrome/browser/extensions/user_script_listener_unittest.cc#newcode293 chrome/browser/extensions/user_script_listener_unittest.cc:293: // Test that when ...
8 years, 3 months ago (2012-09-17 19:25:06 UTC) #2
mmenke
Thanks. http://codereview.chromium.org/10914319/diff/8001/chrome/browser/extensions/user_script_listener_unittest.cc File chrome/browser/extensions/user_script_listener_unittest.cc (right): http://codereview.chromium.org/10914319/diff/8001/chrome/browser/extensions/user_script_listener_unittest.cc#newcode293 chrome/browser/extensions/user_script_listener_unittest.cc:293: // Test that when the script updated notification ...
8 years, 3 months ago (2012-09-17 19:28:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10914319/5
8 years, 3 months ago (2012-09-17 19:30:13 UTC) #4
commit-bot: I haz the power
Commit queue had an internal error. Something went really wrong, probably a crash, a hickup ...
8 years, 3 months ago (2012-09-17 21:19:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10914319/5
8 years, 3 months ago (2012-09-17 21:54:07 UTC) #6
commit-bot: I haz the power
8 years, 3 months ago (2012-09-17 22:06:24 UTC) #7
Change committed as 157211

Powered by Google App Engine
This is Rietveld 408576698