Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10914310: net: Fix clang warnings about missing virtual and OVERRIDE annotations. (Closed)

Created:
8 years, 3 months ago by tfarina
Modified:
8 years, 3 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

net: Fix clang warnings about missing virtual and OVERRIDE annotations. BUG=115047 TBR=eroman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157070

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M net/proxy/proxy_config_service_linux.cc View 7 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
TBRing...
8 years, 3 months ago (2012-09-16 23:30:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/10914310/1
8 years, 3 months ago (2012-09-16 23:30:52 UTC) #2
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 3 months ago (2012-09-17 01:20:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/10914310/1
8 years, 3 months ago (2012-09-17 01:32:17 UTC) #4
commit-bot: I haz the power
Change committed as 157070
8 years, 3 months ago (2012-09-17 03:15:25 UTC) #5
eroman
8 years, 3 months ago (2012-09-17 21:42:10 UTC) #6 
lgtm

Powered by Google App Engine
This is Rietveld 408576698