Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 10914296: Fix missing dependency from app_host to chrome_version_resources (Closed)

Created:
8 years, 3 months ago by erikwright (departed)
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, grt+watch_chromium.org
Visibility:
Public.

Description

Meant to commit this along with the changes in https://chromiumcodereview.appspot.com/10905238/ but pressed the wrong button. This CL is required to ensure clean builds of app_host don't fail. NOTRY=True TBR=huangs,grt,brettw BUG=138315 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157015

Patch Set 1 #

Total comments: 1

Patch Set 2 : sync. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/chrome_browser_extensions.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/10914296/1
8 years, 3 months ago (2012-09-14 20:05:37 UTC) #1
erikwright (departed)
https://chromiumcodereview.appspot.com/10914296/diff/1/chrome/chrome_browser_extensions.gypi File chrome/chrome_browser_extensions.gypi (right): https://chromiumcodereview.appspot.com/10914296/diff/1/chrome/chrome_browser_extensions.gypi#newcode837 chrome/chrome_browser_extensions.gypi:837: '<(DEPTH)/chrome/chrome.gyp:chrome_version_resources', Sorry, should have uploaded an initial patchset equal ...
8 years, 3 months ago (2012-09-14 20:06:33 UTC) #2
brettw
lgtm
8 years, 3 months ago (2012-09-14 22:13:43 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 3 months ago (2012-09-14 23:30:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/10914296/7003
8 years, 3 months ago (2012-09-15 19:14:38 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 3 months ago (2012-09-15 19:49:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/10914296/7003
8 years, 3 months ago (2012-09-15 19:58:27 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-15 20:20:19 UTC) #8
Change committed as 157015

Powered by Google App Engine
This is Rietveld 408576698