Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: lib/compiler/implementation/ssa/builder.dart

Issue 10914286: Remove Object.dynamic. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/ssa/builder.dart
diff --git a/lib/compiler/implementation/ssa/builder.dart b/lib/compiler/implementation/ssa/builder.dart
index 75c7877de8d50ca3b1f5d008465d0361af8e9761..be530d4f43f9aead783d2ef55165adf94234c705 100644
--- a/lib/compiler/implementation/ssa/builder.dart
+++ b/lib/compiler/implementation/ssa/builder.dart
@@ -2407,7 +2407,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
addGenericSendArgumentsToList(link, inputs);
Node type = node.arguments.head;
Node literal = node.arguments.tail.head;
- if (literal is !StringNode || literal.dynamic.isInterpolation) {
+ if (literal is !StringNode || (literal as Dynamic).isInterpolation) {
kasperl 2012/09/14 07:56:33 I understand that you may not want to fix this now
Lasse Reichstein Nielsen 2012/09/17 11:58:06 Still, it sucks. I'll change this.
compiler.cancel('JS code must be a string literal', node: literal);
}
if (type is !LiteralString) {
@@ -2415,7 +2415,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
'The type of a JS expression must be a string literal', node: type);
}
push(new HForeign(
- literal.dynamic.dartString, type.dynamic.dartString, inputs));
+ (literal as Dynamic).dartString, (type as Dynamic).dartString, inputs));
}
void handleForeignUnintercepted(Send node) {

Powered by Google App Engine
This is Rietveld 408576698