Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 10914279: Cleanup: Add a const variable for /proc/self/exe. (Closed)

Created:
8 years, 3 months ago by Lei Zhang
Modified:
8 years, 3 months ago
Reviewers:
Mike Mammarella, brettw
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam
Visibility:
Public.

Description

Cleanup: Add a const variable for /proc/self/exe. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157001

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -20 lines) Patch
M base/base_paths_android.cc View 1 1 chunk +3 lines, -8 lines 0 comments Download
M base/base_paths_posix.cc View 1 4 chunks +4 lines, -7 lines 0 comments Download
M base/process_util.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M base/process_util_linux.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/common/child_process_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/set_process_title.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Lei Zhang
8 years, 3 months ago (2012-09-14 00:54:30 UTC) #1
Mike Mammarella
LGTM
8 years, 3 months ago (2012-09-14 01:05:14 UTC) #2
Lei Zhang
+brettw for OWNERS
8 years, 3 months ago (2012-09-14 03:05:26 UTC) #3
brettw
lgtm https://codereview.chromium.org/10914279/diff/1/base/base_paths_posix.cc File base/base_paths_posix.cc (right): https://codereview.chromium.org/10914279/diff/1/base/base_paths_posix.cc#newcode27 base/base_paths_posix.cc:27: #include "base/process_util.h" I'd put this above and not ...
8 years, 3 months ago (2012-09-14 21:56:52 UTC) #4
Lei Zhang
https://chromiumcodereview.appspot.com/10914279/diff/1/base/base_paths_posix.cc File base/base_paths_posix.cc (right): https://chromiumcodereview.appspot.com/10914279/diff/1/base/base_paths_posix.cc#newcode27 base/base_paths_posix.cc:27: #include "base/process_util.h" On 2012/09/14 21:56:52, brettw wrote: > I'd ...
8 years, 3 months ago (2012-09-14 22:00:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10914279/11001
8 years, 3 months ago (2012-09-14 22:01:12 UTC) #6
commit-bot: I haz the power
Retried try job too often for step(s) interactive_ui_tests, browser_tests
8 years, 3 months ago (2012-09-15 02:13:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10914279/11001
8 years, 3 months ago (2012-09-15 02:19:35 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 3 months ago (2012-09-15 03:00:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10914279/11001
8 years, 3 months ago (2012-09-15 07:17:02 UTC) #10
commit-bot: I haz the power
8 years, 3 months ago (2012-09-15 10:51:07 UTC) #11
Change committed as 157001

Powered by Google App Engine
This is Rietveld 408576698