Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Side by Side Diff: chrome/browser/webdata/web_intents_table_unittest.cc

Issue 10914278: Fix for non-sticky defaults bug. Added a bunch of tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to head Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/webdata/web_intents_table.cc ('k') | net/base/mime_util_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 #include <string> 6 #include <string>
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/file_util.h" 9 #include "base/file_util.h"
10 #include "base/scoped_temp_dir.h" 10 #include "base/scoped_temp_dir.h"
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 s2.type = mime_image; 325 s2.type = mime_image;
326 ASSERT_EQ(URLPattern::PARSE_SUCCESS, 326 ASSERT_EQ(URLPattern::PARSE_SUCCESS,
327 s2.url_pattern.Parse(test_url.spec())); 327 s2.url_pattern.Parse(test_url.spec()));
328 s2.user_date = 1; 328 s2.user_date = 1;
329 s2.suppression = 4; 329 s2.suppression = 4;
330 s2.service_url = test_service_url_2.spec(); 330 s2.service_url = test_service_url_2.spec();
331 ASSERT_TRUE(IntentsTable()->SetDefaultService(s2)); 331 ASSERT_TRUE(IntentsTable()->SetDefaultService(s2));
332 332
333 std::vector<DefaultWebIntentService> defaults; 333 std::vector<DefaultWebIntentService> defaults;
334 ASSERT_TRUE(IntentsTable()->GetAllDefaultServices(&defaults)); 334 ASSERT_TRUE(IntentsTable()->GetAllDefaultServices(&defaults));
335 ASSERT_EQ(3U, defaults.size()); 335 ASSERT_EQ(2U, defaults.size());
336 336
337 ASSERT_TRUE(IntentsTable()->RemoveServiceDefaults(test_service_url)); 337 ASSERT_TRUE(IntentsTable()->RemoveServiceDefaults(test_service_url));
338 338
339 defaults.clear(); 339 defaults.clear();
340 ASSERT_TRUE(IntentsTable()->GetAllDefaultServices(&defaults)); 340 ASSERT_TRUE(IntentsTable()->GetAllDefaultServices(&defaults));
341 ASSERT_EQ(1U, defaults.size()); 341 ASSERT_EQ(1U, defaults.size());
342 EXPECT_EQ(test_service_url_2.spec(), defaults[0].service_url); 342 EXPECT_EQ(test_service_url_2.spec(), defaults[0].service_url);
343 } 343 }
344 344
345 TEST_F(WebIntentsTableTest, OverwriteDefaults) {
346 DefaultWebIntentService default_service;
347 default_service.action = test_action;
348 default_service.type = mime_image;
349 default_service.user_date = 1;
350 default_service.suppression = 4;
351 default_service.service_url = "service_url";
352 ASSERT_TRUE(IntentsTable()->SetDefaultService(default_service));
353
354 default_service.user_date = 2;
355 default_service.service_url = "service_url2";
356 ASSERT_TRUE(IntentsTable()->SetDefaultService(default_service));
357
358 default_service.user_date = 3;
359 default_service.service_url = "service_url3";
360 ASSERT_TRUE(IntentsTable()->SetDefaultService(default_service));
361
362 std::vector<DefaultWebIntentService> defaults;
363 ASSERT_TRUE(IntentsTable()->GetAllDefaultServices(&defaults));
364 ASSERT_EQ(1U, defaults.size());
365 EXPECT_EQ("service_url3", defaults[0].service_url);
366 }
367
345 } // namespace 368 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/webdata/web_intents_table.cc ('k') | net/base/mime_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698