Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 10914276: [Android] Setup OWNERS structure for android_webview (Closed)

Created:
8 years, 3 months ago by joth
Modified:
8 years, 3 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[Android] Setup OWNERS structure for android_webview Explicitly lock down the lib/ directory approvers, while opening the rest of the tree up to the core team. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156723

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M android_webview/OWNERS View 1 chunk +3 lines, -0 lines 2 comments Download
A android_webview/lib/OWNERS View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
joth
8 years, 3 months ago (2012-09-13 22:58:30 UTC) #1
Torne
lgtm
8 years, 3 months ago (2012-09-13 22:59:04 UTC) #2
mnaganov (inactive)
http://codereview.chromium.org/10914276/diff/1/android_webview/OWNERS File android_webview/OWNERS (right): http://codereview.chromium.org/10914276/diff/1/android_webview/OWNERS#newcode7 android_webview/OWNERS:7: steveblock@chromium.org Should we keep Steve's entry?
8 years, 3 months ago (2012-09-13 23:01:05 UTC) #3
mnaganov (inactive)
LGTM http://codereview.chromium.org/10914276/diff/1/android_webview/OWNERS File android_webview/OWNERS (right): http://codereview.chromium.org/10914276/diff/1/android_webview/OWNERS#newcode7 android_webview/OWNERS:7: steveblock@chromium.org On 2012/09/13 23:01:05, Mikhail Naganov (Chromium) wrote: ...
8 years, 3 months ago (2012-09-13 23:23:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/10914276/1
8 years, 3 months ago (2012-09-13 23:28:40 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-14 02:40:11 UTC) #6
Change committed as 156723

Powered by Google App Engine
This is Rietveld 408576698