Send API keys with translate API URL requests.

Send API keys with translate API URL requests.


BUG=145584
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156603

[MAD, 2012-09-13 16:10:02]

Let me know if you prefer I ask someone else for a review.

Takk!

BYE
MAD...

[Jói, 2012-09-13 16:25:02]

LGTM

https://codereview.chromium.org/10914264/diff/1/chrome/browser/translate/tran...
File chrome/browser/translate/translate_manager.cc (right):

https://codereview.chromium.org/10914264/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager.cc:175: if (!api_key.empty()) {
There is no need for this check.  If the key isn't specified, it will be
"dummytoken", not empty, and even if it is empty I think it should be OK to send
"&key=".

[MAD, 2012-09-13 17:23:21]

https://codereview.chromium.org/10914264/diff/1/chrome/browser/translate/tran...
File chrome/browser/translate/translate_manager.cc (right):

https://codereview.chromium.org/10914264/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager.cc:175: if (!api_key.empty()) {
On 2012/09/13 16:25:02, Jói wrote:
> There is no need for this check.  If the key isn't specified, it will be
> "dummytoken", not empty, and even if it is empty I think it should be OK to
send
> "&key=".

OK... Note that I copied the behavior from here:
http://108.166.104.54/xref/chromium/src/content/browser/geolocation/network_l...

Should we fix it there too?

[commit-bot: I haz the power, 2012-09-13 17:23:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mad@chromium.org/10914264/4001

[Jói, 2012-09-13 17:26:32]

> OK... Note that I copied the behavior from here:
>
http://108.166.104.54/xref/chromium/src/content/browser/geolocation/network_l...
>
> Should we fix it there too?

It does no harm, so it's not a big deal, hardly even worth a tracking bug.

Cheers,
Jói



On Thu, Sep 13, 2012 at 5:23 PM,  <mad@chromium.org> wrote:
>
>
https://codereview.chromium.org/10914264/diff/1/chrome/browser/translate/tran...
> File chrome/browser/translate/translate_manager.cc (right):
>
>
https://codereview.chromium.org/10914264/diff/1/chrome/browser/translate/tran...
> chrome/browser/translate/translate_manager.cc:175: if (!api_key.empty())
> {
> On 2012/09/13 16:25:02, Jói wrote:
>>
>> There is no need for this check.  If the key isn't specified, it will
>
> be
>>
>> "dummytoken", not empty, and even if it is empty I think it should be
>
> OK to send
>>
>> "&key=".
>
>
> OK... Note that I copied the behavior from here:
>
http://108.166.104.54/xref/chromium/src/content/browser/geolocation/network_l...
>
> Should we fix it there too?
>
> https://codereview.chromium.org/10914264/

[commit-bot: I haz the power, 2012-09-13 19:32:36]

Change committed as 156603