dart/tools/testing/dart/test_suite.dart - Issue 10914250: Require wrapping for Firefox/Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/tools/testing/dart/test_suite.dart

Issue 10914250: Require wrapping for Firefox/Windows (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/tools/testing/dart/test_suite.dart

diff --git a/dart/tools/testing/dart/test_suite.dart b/dart/tools/testing/dart/test_suite.dart

index 5a20ca17a85def60738938b024e0c949571bd998..659c50da2b4680ff486d09ebb30bcd46334298d6 100644

--- a/dart/tools/testing/dart/test_suite.dart

+++ b/dart/tools/testing/dart/test_suite.dart

@@ -396,6 +396,11 @@ class StandardTestSuite implements TestSuite {

if (TestUtils.isBrowserRuntime(configuration['runtime'])) {

bool isWrappingRequired = configuration['compiler'] != 'dart2js';

+ if (configuration['runtime'] == 'ff' &&

+ Platform.operatingSystem == 'windows') {

+ // TODO(ahe): Investigate why this doesn't work on Windows.

+ isWrappingRequired = true;

+ }

enqueueBrowserTest(info, testName, expectations, isWrappingRequired);

} else {

enqueueStandardTest(info, testName, expectations);

« no previous file with comments | « no previous file | no next file » | no next file with comments »