Issue 10914246: Add some useful features to base::Values:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10914246: Add some useful features to base::Values: (Closed)

Created:
8 years, 3 months ago by not at google - send to devlin

Modified:
8 years, 3 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, erikwright+watch_chromium.org, benwells

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add some useful features to base::Values: - Typed Append methods to ListValue (AppendString etc) including AppendStrings. - Typed SetWithoutPathExpansion methods (SetStringWithoutPathExpansion etc). The latter is important because it's a common mistake to use Set rather than SetWithoutPathExpansion; the existence of these extra methods should help. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156716

Patch Set 1 #

Patch Set 2 : rebase #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -0 lines)			Patch
	M	base/values.h	View	1	2 chunks	+18 lines, -0 lines	0 comments	Download
	M	base/values.cc	View	1	2 chunks	+59 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

8 years, 3 months ago (2012-09-13 22:02:31 UTC) #3

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/10914246/1

Expand Messages | Collapse Messages