Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10914244: Remove support for page_action.icons, and the legacy code surrounding it. (Closed)

Created:
8 years, 3 months ago by Matt Perry
Modified:
8 years, 3 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, Jeffrey Yasskin
Visibility:
Public.

Description

Remove support for page_action.icons, and the legacy code surrounding it. BUG=148602 TBR=isherman@chromium.org,sky@chromium.org,erg@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156681

Patch Set 1 #

Patch Set 2 : fix compile #

Patch Set 3 : docs #

Total comments: 6

Patch Set 4 : don't crash #

Patch Set 5 : upload crashed #

Total comments: 1

Patch Set 6 : constants removed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -254 lines) Patch
M chrome/browser/extensions/api/extension_action/extension_actions_api.cc View 1 2 3 4 5 3 chunks +3 lines, -14 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_page_actions_api.cc View 1 2 3 4 5 4 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_page_actions_api_constants.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_page_actions_api_constants.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/page_action_apitest.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_action_button.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm View 1 2 chunks +4 lines, -22 lines 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 2 chunks +4 lines, -22 lines 0 comments Download
M chrome/browser/ui/views/browser_action_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 1 2 chunks +4 lines, -22 lines 0 comments Download
M chrome/common/extensions/api/page_action.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension.cc View 3 chunks +8 lines, -11 lines 0 comments Download
M chrome/common/extensions/extension_action.h View 5 chunks +4 lines, -25 lines 0 comments Download
M chrome/common/extensions/extension_action.cc View 6 chunks +4 lines, -29 lines 0 comments Download
M chrome/common/extensions/extension_action_unittest.cc View 2 chunks +1 line, -27 lines 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M chrome/common/extensions/extension_unittest.cc View 1 2 3 4 5 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_pageaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/page_action/old_api/set_icon_index.html View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/test/data/extensions/api_test/page_action/old_api/set_icon_index.js View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Matt Perry
jyasskin: fyi yoz: please review
8 years, 3 months ago (2012-09-13 18:54:37 UTC) #1
Yoyo Zhou
This being a legacy feature, there's no documentation to remove?
8 years, 3 months ago (2012-09-13 19:00:14 UTC) #2
Matt Perry
On 2012/09/13 19:00:14, Yoyo Zhou wrote: > This being a legacy feature, there's no documentation ...
8 years, 3 months ago (2012-09-13 19:03:37 UTC) #3
Matt Perry
On 2012/09/13 19:03:37, Matt Perry wrote: > On 2012/09/13 19:00:14, Yoyo Zhou wrote: > > ...
8 years, 3 months ago (2012-09-13 19:07:43 UTC) #4
Matt Perry
http://codereview.chromium.org/10914244/diff/11001/chrome/browser/extensions/api/extension_action/extension_actions_api.cc File chrome/browser/extensions/api/extension_action/extension_actions_api.cc (right): http://codereview.chromium.org/10914244/diff/11001/chrome/browser/extensions/api/extension_action/extension_actions_api.cc#newcode463 chrome/browser/extensions/api/extension_action/extension_actions_api.cc:463: return true; Added this back to avoid a browser ...
8 years, 3 months ago (2012-09-13 19:16:32 UTC) #5
Yoyo Zhou
LGTM http://codereview.chromium.org/10914244/diff/6001/chrome/browser/extensions/api/extension_action/extension_actions_api.cc File chrome/browser/extensions/api/extension_action/extension_actions_api.cc (right): http://codereview.chromium.org/10914244/diff/6001/chrome/browser/extensions/api/extension_action/extension_actions_api.cc#newcode45 chrome/browser/extensions/api/extension_action/extension_actions_api.cc:45: const char kIconIndexOutOfBounds[] = "Page action icon index ...
8 years, 3 months ago (2012-09-13 20:42:39 UTC) #6
Matt Perry
isherman: cocoa OWNERS sky: views OWNERS erg: gtk OWNERS http://codereview.chromium.org/10914244/diff/6001/chrome/browser/extensions/api/extension_action/extension_actions_api.cc File chrome/browser/extensions/api/extension_action/extension_actions_api.cc (right): http://codereview.chromium.org/10914244/diff/6001/chrome/browser/extensions/api/extension_action/extension_actions_api.cc#newcode45 chrome/browser/extensions/api/extension_action/extension_actions_api.cc:45: ...
8 years, 3 months ago (2012-09-13 21:39:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10914244/10021
8 years, 3 months ago (2012-09-13 21:39:35 UTC) #8
commit-bot: I haz the power
8 years, 3 months ago (2012-09-13 23:44:48 UTC) #9 
Change committed as 156681

Powered by Google App Engine
This is Rietveld 408576698