chrome/browser/ui/panels/panel.cc - Issue 10914242: Improve panel tests by properly waiting for expected conditions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel.cc

Issue 10914242: Improve panel tests by properly waiting for expected conditions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: improve AutoResize test, was still flaking Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/panels/panel.cc

diff --git a/chrome/browser/ui/panels/panel.cc b/chrome/browser/ui/panels/panel.cc

index 7ab728305e69b80f67a32c13d4c04a7357389ce6..ac66ad08bebca79dfbcb38f2a0fed9280467e081 100644

--- a/chrome/browser/ui/panels/panel.cc

+++ b/chrome/browser/ui/panels/panel.cc

@@ -261,7 +261,8 @@ panel::Resizability Panel::CanResizeByMouse() const {

}

void Panel::SetPanelBounds(const gfx::Rect& bounds) {

- native_panel_->SetPanelBounds(bounds);

+ if (bounds != native_panel_->GetPanelBounds())

+ native_panel_->SetPanelBounds(bounds);

}

void Panel::SetPanelBoundsInstantly(const gfx::Rect& bounds) {