Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: tools/chrome_remote_control/chrome_remote_control/page_runner.py

Issue 10914237: Port perf.py's _LoginToGoogleAccount to chrome_remote_control (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/chrome_remote_control/chrome_remote_control/page_runner.py
diff --git a/tools/chrome_remote_control/chrome_remote_control/page_runner.py b/tools/chrome_remote_control/chrome_remote_control/page_runner.py
index 675f87d609b691fb25e2d360dbb580956045b319..08846924af498b152c2ee5f87918f1eb69b964d5 100644
--- a/tools/chrome_remote_control/chrome_remote_control/page_runner.py
+++ b/tools/chrome_remote_control/chrome_remote_control/page_runner.py
@@ -30,6 +30,9 @@ class PageRunner(object):
self._server = tab.browser.CreateTemporaryHTTPServer(dirname)
page.url = self._server.UrlOf(filename)
+ if hasattr(page, 'credentials'):
dtu 2012/09/24 21:35:10 if page.credentials: credentials is defined as No
hartmanng 2012/09/26 22:06:15 Done.
+ tab.credentials.LoginNeeded(page.credentials)
+
tab.page.Navigate(page.url)
# TODO(dtu): Detect HTTP redirects.
if page.wait_time_after_navigate:
@@ -38,4 +41,5 @@ class PageRunner(object):
tab.WaitForDocumentReadyStateToBeInteractiveOrBetter()
def CleanUpPage(self):
- pass
+ if hasattr(page, 'credentials'):
+ tab.credentials.LoginNoLongerNeeded(page.credentials)
Ian Vollick 2012/09/25 03:00:18 This causes exceptions. Will need to pass in page
hartmanng 2012/09/26 22:06:15 Done.

Powered by Google App Engine
This is Rietveld 408576698