tools/gpu/page_sets/credentials.json - Issue 10914237: Port perf.py's _LoginToGoogleAccount to chrome_remote_control

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/gpu/page_sets/credentials.json

Issue 10914237: Port perf.py's _LoginToGoogleAccount to chrome_remote_control (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 {

	2 "google_username": null,

	3 "google_password": null,
	tonyg 2012/09/24 20:41:01 are we really going to check the password into the are we really going to check the password into the public repo? Seems more appropriate for src-internal. nduca 2012/09/24 20:50:00 I think this is just an example file to document h I think this is just an example file to document how this works with the intent that we have a real file in src-internal that we pull in. Maybe we should add some notes here. Maybe we should call this empty_credentials.json and a companion file, credentials_format.txt explaining the format? dtu 2012/09/24 21:35:10 I think the script should check this file first an Show quoted text On 2012/09/24 20:50:00, nduca wrote: > I think this is just an example file to document how this works with the intent > that we have a real file in src-internal that we pull in. Maybe we should add > some notes here. Maybe we should call this empty_credentials.json and a > companion file, credentials_format.txt explaining the format? I think the script should check this file first and fall back to the internal file. Then public contributors can put their own credentials in this file to run the test. So empty_credentials.json is not a good name, but a comment would be useful telling people how to use this file.
	4

	5 "google_account_url": null

	6 }

OLD	NEW