Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 10914218: Removing references to legacy packaged apps across extension docs. (Closed)

Created:
8 years, 3 months ago by mkearney1
Modified:
7 years, 2 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Removing references to legacy packaged apps across extension docs. BUG=147662

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -108 lines) Patch
M chrome/common/extensions/docs/server2/templates/articles/autoupdate.html View 1 1 chunk +1 line, -13 lines 7 comments Download
M chrome/common/extensions/docs/server2/templates/articles/devguide.html View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/templates/articles/docs.html View 1 1 chunk +1 line, -12 lines 0 comments Download
M chrome/common/extensions/docs/server2/templates/articles/experimental.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/articles/manifest.html View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/templates/articles/override.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/templates/articles/overview.html View 6 chunks +6 lines, -37 lines 1 comment Download
M chrome/common/extensions/docs/server2/templates/intros/browserAction.html View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/extensions/docs/server2/templates/intros/pageAction.html View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/server2/templates/intros/tts.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/intros/ttsEngine.html View 1 chunk +1 line, -2 lines 1 comment Download
M chrome/common/extensions/docs/server2/templates/public/extensions/index.html View 1 2 chunks +3 lines, -23 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Aaron Boodman
http://codereview.chromium.org/10914218/diff/4001/chrome/common/extensions/docs/server2/templates/articles/autoupdate.html File chrome/common/extensions/docs/server2/templates/articles/autoupdate.html (right): http://codereview.chromium.org/10914218/diff/4001/chrome/common/extensions/docs/server2/templates/articles/autoupdate.html#newcode53 chrome/common/extensions/docs/server2/templates/articles/autoupdate.html:53: ID of an extension by going to the Extensions ...
8 years, 3 months ago (2012-09-16 00:44:35 UTC) #1
Mihai Parparita -not on Chrome
http://codereview.chromium.org/10914218/diff/4001/chrome/common/extensions/docs/server2/templates/articles/autoupdate.html File chrome/common/extensions/docs/server2/templates/articles/autoupdate.html (left): http://codereview.chromium.org/10914218/diff/4001/chrome/common/extensions/docs/server2/templates/articles/autoupdate.html#oldcode55 chrome/common/extensions/docs/server2/templates/articles/autoupdate.html:55: Hosted apps, however, are not listed on the Extensions ...
8 years, 3 months ago (2012-09-16 04:55:02 UTC) #2
Aaron Boodman
http://codereview.chromium.org/10914218/diff/4001/chrome/common/extensions/docs/server2/templates/articles/autoupdate.html File chrome/common/extensions/docs/server2/templates/articles/autoupdate.html (right): http://codereview.chromium.org/10914218/diff/4001/chrome/common/extensions/docs/server2/templates/articles/autoupdate.html#newcode53 chrome/common/extensions/docs/server2/templates/articles/autoupdate.html:53: ID of an extension by going to the Extensions ...
8 years, 3 months ago (2012-09-17 21:18:04 UTC) #3
Aaron Boodman
http://codereview.chromium.org/10914218/diff/4001/chrome/common/extensions/docs/server2/templates/articles/autoupdate.html File chrome/common/extensions/docs/server2/templates/articles/autoupdate.html (left): http://codereview.chromium.org/10914218/diff/4001/chrome/common/extensions/docs/server2/templates/articles/autoupdate.html#oldcode55 chrome/common/extensions/docs/server2/templates/articles/autoupdate.html:55: Hosted apps, however, are not listed on the Extensions ...
8 years, 3 months ago (2012-09-17 21:23:08 UTC) #4
mkearney1
8 years, 3 months ago (2012-09-17 21:30:16 UTC) #5
http://codereview.chromium.org/10914218/diff/4001/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/templates/articles/autoupdate.html
(left):

http://codereview.chromium.org/10914218/diff/4001/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/templates/articles/autoupdate.html:55:
Hosted apps, however, are not listed on the Extensions page.  You can find the
ID of any
Yes, we need the apps stuff to be in apps docs-- it's very confusing talking
about extensions, apps, and hosted apps in same breadth. I have a recommendation
for the manifest which I will send in a separate email to you both. It's not
going to answer every cross-over instance though.
On 2012/09/17 21:23:08, Aaron Boodman wrote:
> On 2012/09/16 04:55:02, Mihai Parparita wrote:
> > Hosted apps are not (publicly) deprecated yet, we shouldn't remove
references
> to
> > them.
> 
> Again, this caveat is something that should only be shown for the apps
> documentation, I think.
> 
> Here's an example:
>
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs...
> -- {{?is_apps}}

http://codereview.chromium.org/10914218/diff/4001/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/templates/articles/autoupdate.html
(right):

http://codereview.chromium.org/10914218/diff/4001/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/templates/articles/autoupdate.html:53: ID
of an extension by going to the Extensions page (<b>chrome://extensions</b>).
I have a to-do to investigate if there are any special circumstances for
autoupdating apps. Assuming there are, then it would seem like we should be very
clear about these. If there aren't, then we could just keep this as is.

On 2012/09/16 04:55:02, Mihai Parparita wrote:
> On 2012/09/16 00:44:35, Aaron Boodman wrote:
> > What did we decide to do about pages like this that describe concepts that
are
> > common to all types of packages?
> 
> Given that this page appears in the apps doc set too
> (http://developer.chrome.com/apps/autoupdate.html), I think the reference to
> packaged apps can stay (it's equally applicable to both legacy and platform
> apps).

Powered by Google App Engine
This is Rietveld 408576698