Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 10914203: Add UMA reporting for audio hardware parameters. (Closed)

Created:
8 years, 3 months ago by DaleCurtis
Modified:
8 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Add UMA reporting for audio hardware parameters. Records bits per channel, channel layout, and sample rate. BUG=147572 TEST=build/run Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156296

Patch Set 1 : Style! #

Total comments: 7

Patch Set 2 : Comments. #

Total comments: 6

Patch Set 3 : Comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -18 lines) Patch
M media/audio/audio_output_resampler.cc View 1 2 2 chunks +43 lines, -0 lines 0 comments Download
M media/audio/sample_rates.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M media/audio/sample_rates.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M media/base/channel_layout.h View 1 2 1 chunk +19 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
DaleCurtis
8 years, 3 months ago (2012-09-11 15:33:21 UTC) #1
scherkus (not reviewing)
https://chromiumcodereview.appspot.com/10914203/diff/2001/media/audio/audio_output_resampler.cc File media/audio/audio_output_resampler.cc (right): https://chromiumcodereview.appspot.com/10914203/diff/2001/media/audio/audio_output_resampler.cc#newcode87 media/audio/audio_output_resampler.cc:87: 40); not worth enumifying a la sample rate? https://chromiumcodereview.appspot.com/10914203/diff/2001/media/audio/audio_output_resampler.cc#newcode89 ...
8 years, 3 months ago (2012-09-11 16:53:31 UTC) #2
DaleCurtis
https://chromiumcodereview.appspot.com/10914203/diff/2001/media/audio/audio_output_resampler.cc File media/audio/audio_output_resampler.cc (right): https://chromiumcodereview.appspot.com/10914203/diff/2001/media/audio/audio_output_resampler.cc#newcode87 media/audio/audio_output_resampler.cc:87: 40); On 2012/09/11 16:53:31, scherkus wrote: > not worth ...
8 years, 3 months ago (2012-09-11 17:35:59 UTC) #3
scherkus (not reviewing)
https://chromiumcodereview.appspot.com/10914203/diff/2001/media/audio/sample_rates.h File media/audio/sample_rates.h (right): https://chromiumcodereview.appspot.com/10914203/diff/2001/media/audio/sample_rates.h#newcode23 media/audio/sample_rates.h:23: k192000Hz = 8, FYI my mac lists 88.2 as ...
8 years, 3 months ago (2012-09-11 17:38:33 UTC) #4
DaleCurtis
http://codereview.chromium.org/10914203/diff/2001/media/audio/audio_output_resampler.cc File media/audio/audio_output_resampler.cc (right): http://codereview.chromium.org/10914203/diff/2001/media/audio/audio_output_resampler.cc#newcode89 media/audio/audio_output_resampler.cc:89: "Media.HardwareAudioChannelLayout", output_params.channel_layout(), On 2012/09/11 16:53:31, scherkus wrote: > I ...
8 years, 3 months ago (2012-09-12 09:50:57 UTC) #5
scherkus (not reviewing)
one q -- fyi your overlapping CLs are starting to confuse me :s http://codereview.chromium.org/10914203/diff/5002/media/audio/audio_output_resampler.cc File ...
8 years, 3 months ago (2012-09-12 13:34:50 UTC) #6
scherkus (not reviewing)
http://codereview.chromium.org/10914203/diff/5002/media/audio/audio_output_resampler.cc File media/audio/audio_output_resampler.cc (right): http://codereview.chromium.org/10914203/diff/5002/media/audio/audio_output_resampler.cc#newcode33 media/audio/audio_output_resampler.cc:33: // TODO(dalecurtis): Since channel mixing is handle by the ...
8 years, 3 months ago (2012-09-12 13:35:13 UTC) #7
DaleCurtis
Done! If you reviewed faster I wouldn't have to keep iterating on top of existing ...
8 years, 3 months ago (2012-09-12 14:03:52 UTC) #8
scherkus (not reviewing)
8 years, 3 months ago (2012-09-12 14:09:22 UTC) #9
lgtm

Powered by Google App Engine
This is Rietveld 408576698