src/api.cc - Issue 10914201: Fix edge case of extension with NULL as source string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 10914201: Fix edge case of extension with NULL as source string. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 8b323b2f1fb7264f3b8da49cf1c491ec33c06742..5c76e32a1b4ec24734b2279c29c1ab8f0f1a428e 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -541,7 +541,9 @@ Extension::Extension(const char* name,

source_(source, source_length_),

dep_count_(dep_count),

deps_(deps),

- auto_enable_(false) { }

+ auto_enable_(false) {

+ CHECK(source != NULL || source_length_ == 0);

v8::Handle<Primitive> Undefined() {

« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »