Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: dart/pkg/unittest/config.dart

Issue 10914197: Revert "Run dart2js tests unmodified in browser." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/lib/compiler/implementation/lib/isolate_patch.dart ('k') | dart/pkg/unittest/test_controller.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/pkg/unittest/config.dart
diff --git a/dart/pkg/unittest/config.dart b/dart/pkg/unittest/config.dart
index 5a8b4bcce5c5814b8fd2f5ef45be2087575945bc..34693dde24f6b99fea5b0c1e0c69527979deaec2 100644
--- a/dart/pkg/unittest/config.dart
+++ b/dart/pkg/unittest/config.dart
@@ -37,9 +37,7 @@ class Configuration {
* tell the vm or browser that tests are still running and the process should
* wait until they are done.
*/
- void onStart() {
- _postMessage('unittest-suite-wait-for-done');
- }
+ void onStart() {}
/**
* Called when each test starts. Useful to show intermediate progress on
@@ -123,11 +121,8 @@ class Configuration {
print('$passed PASSED, $failed FAILED, $errors ERRORS');
}
- if (success) {
- _postMessage('unittest-suite-success');
- } else {
- throw new Exception('Some tests failed.');
- }
+ // An exception is used by the test infrastructure to detect failure.
+ if (!success) throw new Exception("Some tests failed.");
}
String _indent(String str) {
@@ -142,10 +137,4 @@ class Configuration {
// Currently e.message works in dartium, but not in dartc.
handleExternalError(e, String message) =>
_reportTestError('$message\nCaught $e', '');
-
- _postMessage(String message) {
- // In dart2js browser tests, the JavaScript-based test controller
- // intercepts calls to print and listens for "secret" messages.
- print(message);
- }
}
« no previous file with comments | « dart/lib/compiler/implementation/lib/isolate_patch.dart ('k') | dart/pkg/unittest/test_controller.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698