Issue 10914161: Fix ownership of the helper thread in IPCSyncChannelTest.SyncMessageFilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10914161: Fix ownership of the helper thread in IPCSyncChannelTest.SyncMessageFilter (Closed)

Created:
8 years, 3 months ago by piman

Modified:
8 years, 3 months ago

Reviewers:
jam

CC:
chromium-reviews, darin-cc_chromium.org, jam, Timur Iskhodzhanov

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix ownership of the helper thread in IPCSyncChannelTest.SyncMessageFilter The Thread object could (depending on a race) be destroyed on its own thread, which is illegal. Instead, make sure that ownership of the thread is decoupled from the filter to ensure it's destroyed (and joined) on a good thread. BUG=129620 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155547

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -9 lines)			Patch
	M	ipc/ipc_sync_channel_unittest.cc	View		2 chunks	+14 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10914161/1

8 years, 3 months ago (2012-09-07 22:39:29 UTC) #3

Change committed as 155547

Expand Messages | Collapse Messages