Split secure command channel and untrusted application channel

src/trusted/nonnacl_util/sel_ldr_launcher.h

 /* -*- c++ -*- */
 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 // Utility class for launching sel_ldr.
 
@@ skipping 67 matching lines @@
 
   virtual bool Start(const char* url) = 0;
 
   /////////////////////////////////////////////////////////////////////////////
   // After starting the sel_ldr process.
   /////////////////////////////////////////////////////////////////////////////
 
   // Sets up the command channel |command|.
   bool SetupCommand(NaClSrpcChannel* command);
 
+  // Sets up the (|secure|) command channel |command|.

[bsy, 2012/09/07 17:15:53]

is this a stale comment? |secure|?  no such parameter.  and the name is
SetupUntrusteCommand, so why |secure|?

[Petr Hosek, 2012/09/11 18:16:09]

Fixed.

+  bool SetupUntrustedCommand(NaClSrpcChannel* command);
+
   // Load |nexe| over the command channel |command|.
   bool LoadModule(NaClSrpcChannel* command, DescWrapper* nexe);
 
   // Sets up the command channel |command| and sends the SRPC to load |nexe|.
   bool SetupCommandAndLoad(NaClSrpcChannel* command, DescWrapper* nexe);
 
   // Load integrated runtime |irt| over the command channel |command|.
   bool LoadIrt(NaClSrpcChannel* command, DescWrapper* irt);
 
   // Sends the SRPC to start the nexe over |command|.
@@ skipping 107 matching lines @@
   std::vector<nacl::string> application_argv_;
 
   std::vector<Handle> close_after_launch_;
 
   scoped_ptr<SelLdrLocator> sel_ldr_locator_;
 };
 
 }  // namespace nacl
 
 #endif  // NATIVE_CLIENT_SRC_TRUSTED_NONNACL_UTIL_SEL_LDR_LAUNCHER_H_