Issue 10914134: Log the source when a URLFetcher leak is detected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10914134: Log the source when a URLFetcher leak is detected (Closed)

Created:
8 years, 3 months ago by Raghu Simha

Modified:
8 years, 3 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Log the source when a URLFetcher leak is detected Now that we have a mechanism to detect URLFetcher leaks in test suites, we're seeing instances of leaks that are causing redness on the chromium waterfall. However, the logs do not reveal which URLFetcher caused the leak, and makes fixing the problem hard, particularly when the leak is a rarity. This patch adds logging info that specifies the source of the leak. TBR=willchan@chromium.org BUG=146826 TEST=Run a test that leaks a URL, and make sure the logs indicate the source. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155278

Patch Set 1 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	net/url_request/url_request_context.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

8 years, 3 months ago (2012-09-07 01:11:58 UTC) #3

LGTM


On Thu, Sep 6, 2012 at 4:33 PM, <tbreisacher@chromium.org> wrote:

> lgtm
>
>
http://codereview.chromium.**org/10914134/<http://codereview.chromium.org/109...
>

Expand Messages | Collapse Messages