A speculative fix for TSAN and HeapCheck failures in InMemoryURLIndexCacheTest.

A speculative fix for TSAN and HeapCheck failures in InMemoryURLIndexCacheTest.

These failures may be due to poor assumptions that were previously validated as a side-effect of code that I removed.

Basically, the test is reaching into the history service and grabbing its DB, then accessing it off of the service's thread. This is fundamentally wrong but would still work if you wait until the history service is completely idle. Previously  BlockUntilBookmarkModelLoaded might have had this side-effect.

I was unable to repro the failure locally with TSan, so removing the suppressions and observing to see if the problem recurs.

R=timurrrr@chromium.org,sky@chromium.org
BUG=146322, 146265
TEST=observe TSan/Heapcheck bots.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156840

[Timur Iskhodzhanov, 2012-09-06 18:48:21]

Would be nice to have a TODO with a link to the bug explaining
this issue so someone else won't re-remove the call later.

Suppressions - LGTM if you watch the bots for a couple of cycles after
you commit

[sky, 2012-09-06 20:30:38]

LGTM

[commit-bot: I haz the power, 2012-09-14 15:38:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erikwright@chromium.org/10914125/5001

[commit-bot: I haz the power, 2012-09-14 17:42:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erikwright@chromium.org/10914125/5001

[commit-bot: I haz the power, 2012-09-14 18:11:22]

Change committed as 156840