Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: Source/WebCore/rendering/RenderQuote.h

Issue 10914111: Merge 125737 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1229/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebCore/rendering/RenderObjectChildList.cpp ('k') | Source/WebCore/rendering/RenderRegion.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/rendering/RenderQuote.h
===================================================================
--- Source/WebCore/rendering/RenderQuote.h (revision 127654)
+++ Source/WebCore/rendering/RenderQuote.h (working copy)
@@ -44,6 +44,11 @@
virtual PassRefPtr<StringImpl> originalText() const OVERRIDE;
virtual void computePreferredLogicalWidths(float leadWidth) OVERRIDE;
+ // We don't override insertedIntoTree to call attachQuote() as it would be attached
+ // too early and get the wrong depth since generated content is inserted into anonymous
+ // renderers before going into the main render tree. Once we can ensure that insertIntoTree,
+ // is called on an attached tree, we should override it here.
+
const QuotesData* quotesData() const;
void updateDepth();
bool isAttached() { return m_attached; }
« no previous file with comments | « Source/WebCore/rendering/RenderObjectChildList.cpp ('k') | Source/WebCore/rendering/RenderRegion.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698