Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10914103: Merged r12440, r12441, r12445, r12446, r12443 into 3.12 branch. (Closed)

Created:
8 years, 3 months ago by danno
Modified:
8 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Merged r12440, r12441, r12445, r12446, r12443 into 3.12 branch. Add build system infrastructure for ENABLE_EXTRA_CHECKS flag (not used yet) Fix missing colon in common.gypi Add empty-handle checks to API functions (#ifdef ENABLE_EXTRA_CHECKS) Check the return value of API calls on ia32 and x64. Push stacktrace and die if the receiver is of unknown type. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12450

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -65 lines) Patch
M Makefile View 1 chunk +7 lines, -0 lines 0 comments Download
M build/common.gypi View 2 chunks +6 lines, -0 lines 0 comments Download
M src/api.h View 4 chunks +36 lines, -59 lines 0 comments Download
M src/api.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M src/checks.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M src/isolate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/objects.cc View 2 chunks +17 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
danno
8 years, 3 months ago (2012-09-05 18:42:33 UTC) #1
Jakob Kummerow
8 years, 3 months ago (2012-09-05 18:47:17 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698