Issue 10914102: history.{push,replace}State should no longer be V8EnabledAtRuntime

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10914102: history.{push,replace}State should no longer be V8EnabledAtRuntime (Closed)

Created:
8 years, 3 months ago by Mihai Parparita -not on Chrome

Modified:
8 years, 3 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

history.{push,replace}State should no longer be V8EnabledAtRuntime http://trac.webkit.org/changeset/55549 made them be runtime-enabled (since the Chromium implementation was not complete at the time), but they've been enabled by default since http://crrev.com/41850. As of http://trac.webkit.org/changeset/127674, WebRuntimeFeatures::enablePushState is a no-op. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155205

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -4 lines)			Patch
M	content/renderer/render_thread_impl.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	webkit/support/test_webkit_platform_support.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_webkit_init.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/10914102/1

8 years, 3 months ago (2012-09-06 14:39:32 UTC) #3

commit-bot: I haz the power

8 years, 3 months ago (2012-09-06 16:32:22 UTC) #4

Try job failure for 10914102-1 (retry) on mac_rel for step
"sync_integration_tests".
It's a second try, previously, step "sync_integration_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Expand Messages | Collapse Messages