Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issue 10914080: Make jar targets remove .class files before compile (Closed)

Created:
8 years, 3 months ago by cjhopman
Modified:
8 years, 3 months ago
Reviewers:
nilesh
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Make jar targets remove .class files before compile Jar targets package all .class files in their output directory into the final jar. It should only package those that are actually from .java files in the src directories. Specifically, it should not package .class files from .java files that used to be in the src directory but are no longer there. To prevent packaging these stale .class files, clean the output directory before the compile step. One side effect is that we will now have to compile all .java files for a target each time that that target is rebuilt. And in turn, the _java targets that depend on it will do the same. Locally, when building the chrome_java target (which includes all the others) after touching a base_java input (which will then force all the others to rebuild), this adds ~3 seconds to the build time... i.e. it's only a very minor hit. BUG=145983 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -8 lines) Patch
M build/android/ant/chromium-jars.xml View 4 chunks +31 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cjhopman
8 years, 3 months ago (2012-09-04 21:04:07 UTC) #1
nilesh
On 2012/09/04 21:04:07, cjhopman wrote: LGTM
8 years, 3 months ago (2012-09-04 21:23:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/10914080/1
8 years, 3 months ago (2012-09-04 21:50:09 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-04 23:55:40 UTC) #4
Change committed as 154857

Powered by Google App Engine
This is Rietveld 408576698